cleanup: apply VS code cleanups (#423)

Author: natemcmaster

.editorconfig

@@ -48,15 +48,34 @@ csharp_style_expression_bodied_indexers                                = true
 csharp_style_expression_bodied_accessors                               = true
 csharp_style_throw_expression                                          = true
 
+# Default severity for analyzer diagnostics with category 'Style' (escalated to build warnings)
+# dotnet_analyzer_diagnostic.category-Style.severity                     = suggestion
+
+# Required naming sylte
+dotnet_diagnostic.IDE0006.severity = error
+
+# suppress warning aboud unused methods
+dotnet_diagnostic.IDE0051.severity = none
+
+# Missing required header
+dotnet_diagnostic.IDE0073.severity = error
+
+# Remove unnecessary parenthesis
+dotnet_diagnostic.IDE0047.severity = warning
+
+# Parenthesis added for clarity
+dotnet_diagnostic.IDE0048.severity = warning
+
 # Naming styles
 
 ## Constants are PascalCase
 dotnet_naming_style.pascal_case.capitalization                         = pascal_case
 
-dotnet_naming_symbols.constants.applicable_kinds                       = *
-dotnet_naming_symbols.constants.required_modifiers                     = const
+dotnet_naming_symbols.const.applicable_kinds                       = field, property
+dotnet_naming_symbols.const.applicable_accessibilities             = *
+dotnet_naming_symbols.const.required_modifiers                     = const
 
-dotnet_naming_rule.constants_should_be_pascale_case.symbols            = constants
+dotnet_naming_rule.constants_should_be_pascale_case.symbols            = const
 dotnet_naming_rule.constants_should_be_pascale_case.style              = pascal_case
 dotnet_naming_rule.constants_should_be_pascale_case.severity           = error
 

Directory.Build.props

@@ -31,6 +31,7 @@
     <SuppressNETCoreSdkPreviewMessage>true</SuppressNETCoreSdkPreviewMessage>
     <WarningsNotAsErrors>$(WarningsNotAsErrors);1591</WarningsNotAsErrors>
     <LangVersion>9.0</LangVersion>
+    <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
     <Nullable>annotations</Nullable>
     <AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)src\StrongName.snk</AssemblyOriginatorKeyFile>
     <SignAssembly>true</SignAssembly>

src/CommandLineUtils/Abstractions/ParseResult.cs

@@ -2,7 +2,6 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
-using System.ComponentModel;
 
 namespace McMaster.Extensions.CommandLineUtils.Abstractions
 {

src/CommandLineUtils/Abstractions/ValueParserProvider.cs

@@ -14,8 +14,8 @@ namespace McMaster.Extensions.CommandLineUtils.Abstractions
     /// </summary>
     public class ValueParserProvider
     {
-        private readonly Dictionary<Type, IValueParser> _parsers = new Dictionary<Type, IValueParser>(10);
-        private readonly TypeDescriptorValueParserFactory _defaultValueParserFactory = new TypeDescriptorValueParserFactory();
+        private readonly Dictionary<Type, IValueParser> _parsers = new(10);
+        private readonly TypeDescriptorValueParserFactory _defaultValueParserFactory = new();
 
         internal ValueParserProvider()
         {
@@ -48,7 +48,7 @@ internal ValueParserProvider()
         /// </remarks>
         public CultureInfo ParseCulture { get; set; } = CultureInfo.CurrentCulture;
 
-        private static readonly MethodInfo s_GetParserGeneric
+        private static readonly MethodInfo s_getParserGeneric
             = typeof(ValueParserProvider)
                 .GetMethods(BindingFlags.Instance | BindingFlags.Public)
                 .Single(m => m.Name == nameof(GetParser) && m.IsGenericMethod);
@@ -60,7 +60,7 @@ private static readonly MethodInfo s_GetParserGeneric
         /// <returns></returns>
         public IValueParser GetParser(Type type)
         {
-            var method = s_GetParserGeneric.MakeGenericMethod(type);
+            var method = s_getParserGeneric.MakeGenericMethod(type);
             return (IValueParser)method.Invoke(this, Util.EmptyArray<object>());
         }
 
@@ -221,9 +221,11 @@ public GenericParserAdapter(IValueParser inner)
 
             public Type TargetType => _inner.TargetType;
 
-            public T Parse(string? argName, string? value, CultureInfo culture) => (T)_inner.Parse(argName, value, culture)!;
+            public T Parse(string? argName, string? value, CultureInfo culture)
+                => (T)_inner.Parse(argName, value, culture)!;
 
-            object? IValueParser.Parse(string? argName, string? value, CultureInfo culture) => _inner.Parse(argName, value, culture);
+            object? IValueParser.Parse(string? argName, string? value, CultureInfo culture)
+                => _inner.Parse(argName, value, culture);
         }
     }
 }

src/CommandLineUtils/Attributes/AllowedValuesAttribute.cs

@@ -57,18 +57,12 @@ private static string GetDefaultError(string[] allowedValues)
         /// </summary>
         public bool IgnoreCase
         {
-            get
-            {
-                return Comparer == StringComparison.CurrentCultureIgnoreCase
-                    || Comparer == StringComparison.InvariantCultureIgnoreCase
-                    || Comparer == StringComparison.OrdinalIgnoreCase;
-            }
-            set
-            {
-                Comparer = value
+            get => Comparer is StringComparison.CurrentCultureIgnoreCase
+                    or StringComparison.InvariantCultureIgnoreCase
+                    or StringComparison.OrdinalIgnoreCase;
+            set => Comparer = value
                     ? StringComparison.CurrentCultureIgnoreCase
                     : StringComparison.CurrentCulture;
-            }
         }
 
         /// <inheritdoc />

src/CommandLineUtils/Attributes/CommandAttribute.cs

@@ -3,7 +3,6 @@
 
 using System;
 using System.Collections.Generic;
-using System.ComponentModel;
 using System.Globalization;
 using System.Linq;
 

src/CommandLineUtils/Attributes/FilePathExistsAttributeBase.cs

@@ -29,7 +29,7 @@ internal FilePathExistsAttributeBase(FilePathType filePathType)
         /// <inheritdoc />
         protected override ValidationResult IsValid(object value, ValidationContext validationContext)
         {
-            if (!(value is string path) || path.Length == 0 || path.IndexOfAny(Path.GetInvalidPathChars()) >= 0)
+            if (value is not string path || path.Length == 0 || path.IndexOfAny(Path.GetInvalidPathChars()) >= 0)
             {
                 return new ValidationResult(FormatErrorMessage(value as string));
             }

src/CommandLineUtils/Attributes/FilePathNotExistsAttributeBase.cs

@@ -29,7 +29,7 @@ internal FilePathNotExistsAttributeBase(FilePathType filePathType)
         /// <inheritdoc />
         protected override ValidationResult IsValid(object value, ValidationContext validationContext)
         {
-            if (!(value is string path) || path.Length == 0 || path.IndexOfAny(Path.GetInvalidPathChars()) >= 0)
+            if (value is not string path || path.Length == 0 || path.IndexOfAny(Path.GetInvalidPathChars()) >= 0)
             {
                 return new ValidationResult(FormatErrorMessage(value as string));
             }
@@ -50,7 +50,7 @@ protected override ValidationResult IsValid(object value, ValidationContext vali
                 return ValidationResult.Success;
             }
 
-            if ((_filePathType == FilePathType.Any) && (!File.Exists(path) && !Directory.Exists(path)))
+            if ((_filePathType == FilePathType.Any) && !File.Exists(path) && !Directory.Exists(path))
             {
                 return ValidationResult.Success;
             }

src/CommandLineUtils/Attributes/SubcommandAttribute.cs

@@ -2,7 +2,6 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
-using System.ComponentModel;
 
 #pragma warning disable 618
 
@@ -15,7 +14,7 @@ namespace McMaster.Extensions.CommandLineUtils
     public sealed class SubcommandAttribute : Attribute
     {
         /// <summary>
-        /// Initializes a new instance of <see cref="McMaster.Extensions.CommandLineUtils.SubcommandAttribute" />.
+        /// Initializes a new instance of <see cref="SubcommandAttribute" />.
         /// </summary>
         /// <param name="subcommands">The subcommand types.</param>
         public SubcommandAttribute(params Type[] subcommands)

src/CommandLineUtils/CommandArgument.cs

@@ -1,5 +1,6 @@
 // Copyright (c) Nate McMaster.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
 // This file has been modified from the original form. See Notice.txt in the project root for more information.
 
 using System;
@@ -16,7 +17,7 @@ namespace McMaster.Extensions.CommandLineUtils
     /// <seealso cref="CommandOption"/>
     public class CommandArgument
     {
-        private protected List<string?> _values = new List<string?>();
+        private protected List<string?> _values = new();
 
         /// <summary>
         /// The name of the argument.