This repository was archived by the owner on Sep 3, 2021. It is now read-only.
fix: fix types and remove typesVersions #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates aegir and fixes errors with the new ts config and removes typesVersions. `typesVersions` workaround makes TS rewrite imports to `cids` to `cids/src` and because this package doesn't really needs this a workaround its just removed. This should fix libp2p/js-libp2p#839 (comment)
rvagg
suggested changes
Jan 10, 2021
test/cid-util.spec.js
Outdated
| before(async () => { | ||
| hash = await multihashing(uint8ArrayFromString('abc'), 'sha2-256') | ||
| }) | ||
| describe('CIDUtil', async () => { |
There was a problem hiding this comment.
I don't believe async for describe is supported. It'll work if this can be done within a tick (or so? there's some amount of time that mocha uses to collect all of the tests after running describe()s), but if there's more than a tiny delay then the tests will get entirely dropped from the suite. Doing the setup in an async before() is the safest bet.
running with 8.2.1, this runs a single test:
describe('foo', async () => {
await new Promise((resolve) => setImmediate(resolve))
it('bar', () => {})
})but this doesn't run any:
describe('foo', async () => {
await new Promise((resolve) => setTimeout(resolve, 0))
it('bar', () => {})
})did you also mean to add the @type to this one like in index.spec.js?
vasco-santos
approved these changes
Jan 11, 2021
|
|
rvagg
approved these changes
Jan 12, 2021
vmx
approved these changes
Jan 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates aegir and fixes errors with the new ts config and removes typesVersions.
typesVersionsworkaround makes TS rewrite imports tocidstocids/srcand because this package doesn't really needs this a workaround its just removed.This should fix libp2p/js-libp2p#839 (comment)