Skip to content

Commit 1e03555

Browse files
minusdavidfridobox
authored andcommitted
Bug 25777: Disable misleading datatables table information display z3950
This patch disables the table information display on z3950_search.pl, since it only includes search result counts for that page, which is misleading to end users. To test: 1) Do not apply the patch 2) Do a Z39.50 search from cataloguing for "test" against Library of Congress. 3) Note the bottom of the page says "Show 1 to 20 of 20" and "Showing page 1 of 501" 4) Do a Z39.50 search from Acquisitions for "test" against Library of Congress (Acquisitions -> Vendor -> Basket -> Add to basket -> From external source). 5) Apply the patch and restart Plack 6) Repeat Step #2 7) Note the bottom of the page now only says "Showing page 1 of 501" 8) Note the search bar is gone 9) Repeat step #4 10) Note the bottom of the page now only says "Showing page 1 of 501" 11) Note the search bar is gone Squashed and mixed authorship added below Co-authored-by: Owen Leonard <[email protected]> Co-authored-by: Martin Renvoize <[email protected]> Signed-off-by: Owen Leonard <[email protected]> Signed-off-by: David Cook <[email protected]> Signed-off-by: Martin Renvoize <[email protected]> Signed-off-by: Jonathan Druart <[email protected]> (cherry picked from commit 2a2a04a) Signed-off-by: Fridolin Somers <[email protected]>
1 parent 934e033 commit 1e03555

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,9 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color :
240240
{ "aTargets": [ 1 ], "sType": "nsb-nse" },
241241
],
242242
"aaSorting": [[ 1, "asc" ]],
243-
"bPaginate": false
243+
"bPaginate": false,
244+
"searching": false,
245+
"bInfo":false
244246
}));
245247
});
246248
</script>

koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,9 @@
248248
{ "aTargets": [ 1 ], "sType": "nsb-nse" },
249249
],
250250
"aaSorting": [[ 1, "asc" ]],
251-
"bPaginate": false
251+
"bPaginate": false,
252+
"searching": false,
253+
"bInfo":false
252254
}, columns_settings );
253255
});
254256

0 commit comments

Comments
 (0)