Skip to content

Commit 3ba9864

Browse files
WebGPURenderer: Fix mat2() arguments (#30543)
* WebGPURenderer: Fix matN() and matN(x) behaviors * simplify the code since luckily the nodebuilder fallback all values to zero if no arguments * from specs scalar x spread on diagonal * even more simple * partial revert
1 parent cb5d4de commit 3ba9864

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/nodes/core/NodeBuilder.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1160,11 +1160,11 @@ class NodeBuilder {
11601160

11611161
return `${ this.getType( type ) }( ${ generateConst( value.x ) }, ${ generateConst( value.y ) }, ${ generateConst( value.z ) } )`;
11621162

1163-
} else if ( typeLength === 4 ) {
1163+
} else if ( typeLength === 4 && type !== 'mat2' ) {
11641164

11651165
return `${ this.getType( type ) }( ${ generateConst( value.x ) }, ${ generateConst( value.y ) }, ${ generateConst( value.z ) }, ${ generateConst( value.w ) } )`;
11661166

1167-
} else if ( typeLength > 4 && value && ( value.isMatrix3 || value.isMatrix4 ) ) {
1167+
} else if ( typeLength >= 4 && value && ( value.isMatrix2 || value.isMatrix3 || value.isMatrix4 ) ) {
11681168

11691169
return `${ this.getType( type ) }( ${ value.elements.map( generateConst ).join( ', ' ) } )`;
11701170

0 commit comments

Comments
 (0)