CSHARP-4938: Support for indexing and querying on UUID and null datatype #1563
Conversation
| /// Creates a search definition that queries for documents where an indexed field is equal | ||
| /// to the specified value. | ||
| /// Supported value types are boolean, numeric, ObjectId and date. | ||
| /// Supported value types are null, boolean, numeric, ObjectId, Guid and date. |
There was a problem hiding this comment.
Need to add the Guid comment also to In operator?
| [BsonElement("testString")] | ||
| public string TestString { get; set; } | ||
|
|
||
| [BsonGuidRepresentation(GuidRepresentation.Standard)] |
There was a problem hiding this comment.
You mean to have both attributes on one line?
There was a problem hiding this comment.
Oh sorry it's all good, on the smaller laptop screen it seemed like there is an extra empty line.
| new object[] { DateTimeOffset.MaxValue, "ISODate(\"9999-12-31T23:59:59.999Z\")", Exp(p => p.DateTimeOffset), nameof(Person.DateTimeOffset) }, | ||
| new object[] { ObjectId.Empty, "{ $oid: '000000000000000000000000' }", Exp(p => p.Id), "_id" } | ||
| new object[] { ObjectId.Empty, "{ $oid: '000000000000000000000000' }", Exp(p => p.Id), "_id" }, | ||
| new object[] { Guid.Empty, """{ "$binary" : { "base64" : "AAAAAAAAAAAAAAAAAAAAAA==", "subType" : "04" } }""", Exp(p => p.Guid), nameof(Person.Guid) }, |
There was a problem hiding this comment.
'Raw string literals', nice feature! TIL
adelinowona
left a comment
adelinowona
left a comment
There was a problem hiding this comment.
LGTM except for one comment
BorisDog
left a comment
BorisDog
left a comment
There was a problem hiding this comment.
LGTM! + Last minor comment about to update the In doc.
| [BsonElement("testString")] | ||
| public string TestString { get; set; } | ||
|
|
||
| [BsonGuidRepresentation(GuidRepresentation.Standard)] |
There was a problem hiding this comment.
Oh sorry it's all good, on the smaller laptop screen it seemed like there is an extra empty line.
| TField value, | ||
| SearchScoreDefinition<TDocument> score = null) | ||
| where TField : struct, IComparable<TField> => | ||
| where TField : IComparable<TField> => |
There was a problem hiding this comment.
Can we remove this IComparable constraint as well? Looking at the code path we don't do any comparing ourselves, we just render the value in the search stage. I actually don't see a benefit for us if we are not doing the comparing. I tried testing removing all the type constraints here, and everything still works and evergreen doesn't report any breaking changes. Thoughts? @BorisDog
There was a problem hiding this comment.
I agree that this can be removed safely and just did it.
|
Just added the test collections on the common cluster. Waiting for the CI to be green and then I'll merge |
3 participants
No description provided.