Merge pull request #1 from gribnoysup/resolve-on-close

fix: Call resolve in the close callback

Author: gribnoysup

package.json

@@ -48,8 +48,8 @@
   "devDependencies": {
     "@types/mocha": "^8.0.3",
     "@types/node": "^16.4.10",
-    "@typescript-eslint/eslint-plugin": "^4.2.0",
-    "@typescript-eslint/parser": "^4.2.0",
+    "@typescript-eslint/eslint-plugin": "^5.30.7",
+    "@typescript-eslint/parser": "^5.30.7",
     "eslint": "^7.9.0",
     "eslint-config-semistandard": "^15.0.1",
     "eslint-config-standard": "^14.1.1",
@@ -62,7 +62,7 @@
     "mongodb": "^4.0.1",
     "mongodb-runner": "^4.8.3",
     "nyc": "^15.1.0",
-    "ts-node": "^9.0.0",
-    "typescript": "^4.3.5"
+    "ts-node": "^10.9.1",
+    "typescript": "^4.7.4"
   }
 }

src/parse-stream.ts

@@ -32,7 +32,8 @@ export class WireProtocolParser extends Writable {
       }
       callback();
     } catch (err) {
-      callback(err);
+      // eslint-disable-next-line standard/no-callback-literal
+      callback(err as Error);
     }
   }
 }

src/proxy.ts

@@ -86,6 +86,8 @@ export class Proxy extends EventEmitter {
   }
 
   async close(): Promise<void> {
-    await new Promise<void>((resolve, reject) => this.srv.close((err) => err ? reject(err) : resolve));
+    await new Promise<void>((resolve, reject) =>
+      this.srv.close((err) => (err ? reject(err) : resolve()))
+    );
   }
 }

test/index.ts

@@ -30,7 +30,7 @@ describe('Proxy', function() {
 
   afterEach(async() => {
     await client.close();
-    proxy.close();
+    await proxy.close();
   });
 
   it('records ismaster events', async() => {