chore(shell-bson): split shell BSON logic into separate package (#2537)

This is admittedly a large refactor, but one that I would believe is generally
worth it:

- Moving the BSON print handling out of `service-provider-core` makes sense,
  as `service-provider-core` is generally intended to be a library
  providing an *interface*, not partial implementations.
- Moving the BSON classes out of `shell-api` is less architecturally important,
  but it does provide a little bit of additional encapsulation.
  It does, for example, force us to separate mongosh-specific `.help` property
  from core BSON constructor logic.
- A number of files in other packages were using `@mongosh/service-provider-core`
  only as a convenient way of getting the current `bson` package,
  which works but is really more of a hack and there's no good reason
  not to just use the `bson` package that the driver team ships
  directly.

This is also convenient on a broader basis, though, because it makes
mongosh's BSON constructors generally available for other projects with
similar needs to use. In Compass, we are avoiding this by using a Babel-based
"manual JavaScript evaluator", but not all projects have the same
technical requirements as Compass, and some may prefer the flexibility
of a full-fledged JS execution environment like mongosh does.

Author: addaleax

.evergreen.yml

@@ -152,8 +152,9 @@
     "packages/types",
     "packages/i18n",
     "packages/logging",
-    "packages/service-provider-core",
+    "packages/shell-bson",
     "packages/arg-parser",
+    "packages/service-provider-core",
     "packages/service-provider-node-driver",
     "packages/shell-api",
     "packages/autocomplete",

package-lock.json

@@ -37,7 +37,7 @@
   "dependencies": {
     "@mongosh/errors": "2.4.4",
     "@mongosh/i18n": "^2.15.4",
-    "mongodb-connection-string-url": "^3.0.1"
+    "mongodb-connection-string-url": "^3.0.2"
   },
   "devDependencies": {
     "@mongodb-js/devtools-connect": "^3.9.4",

package.json

@@ -63,6 +63,8 @@
     "@mongosh/i18n": "^2.15.4",
     "@mongosh/node-runtime-worker-thread": "3.3.24",
     "@mongosh/service-provider-core": "3.5.0",
+    "@mongosh/shell-bson": "1.0.0",
+    "bson": "^6.10.4",
     "numeral": "^2.0.6",
     "text-table": "^0.2.0"
   },

packages/arg-parser/package.json

@@ -1,4 +1,4 @@
-import { bson } from '@mongosh/service-provider-core';
+import * as bson from 'bson';
 import { expect } from 'chai';
 import { inspect } from './inspect';
 

packages/browser-repl/package.json

@@ -1,6 +1,7 @@
 import type { CustomInspectFunction } from 'util';
 import { inspect as utilInspect } from 'util';
-import { bsonStringifiers } from '@mongosh/service-provider-core';
+import * as bson from 'bson';
+import { makeBsonStringifiers } from '@mongosh/shell-bson';
 
 // At the time of writing, the Compass dist package contains what appear to be
 // 155 different copies of the 'bson' module. It is impractical to attach
@@ -65,6 +66,7 @@ function attachInspectMethods(obj: any): void {
     attachInspectMethods(value);
   }
 
+  const bsonStringifiers = makeBsonStringifiers(bson);
   // Add obj[util.inspect.custom] if it does not exist and we can provide it.
   const bsontype = obj._bsontype as keyof typeof bsonStringifiers;
   if (

packages/browser-repl/src/components/utils/inspect.spec.ts

@@ -1,7 +1,7 @@
 import { IframeRuntime } from './iframe-runtime';
 import { expect } from '../../testing/chai';
 import type { ServiceProvider } from '@mongosh/service-provider-core';
-import { bson } from '@mongosh/service-provider-core';
+import * as bson from 'bson';
 
 describe('IframeRuntime', function () {
   let runtime;

packages/browser-repl/src/components/utils/inspect.ts

@@ -44,6 +44,7 @@
     "@mongosh/service-provider-node-driver": "^3.16.0",
     "@types/sinon": "^7.5.1",
     "@types/sinon-chai": "^3.2.4",
+    "bson": "^6.10.4",
     "depcheck": "^1.4.7",
     "eslint": "^7.25.0",
     "prettier": "^2.8.8",

packages/browser-repl/src/iframe-runtime/iframe-runtime.spec.ts

@@ -6,7 +6,7 @@ chai.use(sinonChai);
 const { expect } = chai;
 
 import { NodeDriverServiceProvider } from '@mongosh/service-provider-node-driver';
-import { bson } from '@mongosh/service-provider-core';
+import * as bson from 'bson';
 import { ElectronRuntime } from './electron-runtime';
 import { EventEmitter } from 'events';
 import type { RuntimeEvaluationListener } from '@mongosh/browser-runtime-core';