chore: use custom isObjectEmpty that is O(1) instead of O(N). Important for large schemas

Author: kmruiz

src/helpers/isObjectEmpty.ts

@@ -0,0 +1,15 @@
+type EmptyObject = { [x: string]: never } | null | undefined;
+
+export function isObjectEmpty(value: object | null | undefined): value is EmptyObject {
+    if (!value) {
+        return true;
+    }
+
+    for (const prop in value) {
+        if (Object.prototype.hasOwnProperty.call(value, prop)) {
+            return false;
+        }
+    }
+
+    return true;
+}

src/tools/mongodb/metadata/collectionSchema.ts

@@ -6,6 +6,7 @@ import { getSimplifiedSchema } from "mongodb-schema";
 import z from "zod";
 import { ONE_MB } from "../../../helpers/constants.js";
 import { collectCursorUntilMaxBytesLimit } from "../../../helpers/collectCursorUntilMaxBytes.js";
+import { isObjectEmpty } from "../../../helpers/isObjectEmpty.js";
 
 export class CollectionSchemaTool extends MongoDBToolBase {
     public name = "collection-schema";
@@ -32,8 +33,7 @@ export class CollectionSchemaTool extends MongoDBToolBase {
         });
         const schema = await getSimplifiedSchema(documents);
 
-        const fieldsCount = Object.entries(schema).length;
-        if (fieldsCount === 0) {
+        if (isObjectEmpty(schema)) {
             return {
                 content: [
                     {

tests/integration/common/isObjectEmpty.test.ts

@@ -0,0 +1,20 @@
+import { isObjectEmpty } from "../../../src/helpers/isObjectEmpty.js";
+import { describe, expect, it } from "vitest";
+
+describe("isObjectEmpty", () => {
+    it("returns true for null", () => {
+        expect(isObjectEmpty(null)).toBe(true);
+    });
+    
+    it("returns true for undefined", () => {
+        expect(isObjectEmpty(undefined)).toBe(true);
+    });
+
+    it("returns true for empty object", () => {
+        expect(isObjectEmpty({})).toBe(true);
+    });
+
+    it("returns false for object with properties", () => {
+        expect(isObjectEmpty({ a: 1 })).toBe(false);
+    });
+});