test: add cluster tests

Author: fmenezes

.github/workflows/tests_daily.yaml renamed to .github/workflows/atlas_tests.yaml

@@ -1,9 +1,6 @@
 ---
-name: Code Health
+name: Atlas Tests
 on:
-  push:
-    branches:
-      - main
   pull_request:
 jobs:
   run-tests-daily:

.github/workflows/code_health.yaml

@@ -20,6 +20,20 @@ jobs:
       - name: Run style check
         run: npm run check
 
+  check-generate:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: GitHubSecurityLab/actions-permissions/monitor@v1
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version-file: package.json
+          cache: "npm"
+      - name: Install dependencies
+        run: npm ci
+      - name: Run style check
+        run: npm run generate
+
   run-tests:
     strategy:
       matrix:

package-lock.json

@@ -53,7 +53,8 @@
     "ts-jest": "^29.3.1",
     "tsx": "^4.19.3",
     "typescript": "^5.8.2",
-    "typescript-eslint": "^8.29.1"
+    "typescript-eslint": "^8.29.1",
+    "yaml": "^2.7.1"
   },
   "dependencies": {
     "@modelcontextprotocol/sdk": "^1.8.0",

package.json

@@ -2,18 +2,22 @@ import fs from "fs/promises";
 import { OpenAPIV3_1 } from "openapi-types";
 import argv from "yargs-parser";
 
-function findParamFromRef(ref: string, openapi: OpenAPIV3_1.Document): OpenAPIV3_1.ParameterObject {
+function findObjectFromRef<T>(obj: T | OpenAPIV3_1.ReferenceObject, openapi: OpenAPIV3_1.Document): T {
+    const ref = (obj as OpenAPIV3_1.ReferenceObject).$ref;
+    if (ref === undefined) {
+        return obj as T;
+    }
     const paramParts = ref.split("/");
     paramParts.shift(); // Remove the first part which is always '#'
-    let param: any = openapi; // eslint-disable-line @typescript-eslint/no-explicit-any
+    let foundObj: any = openapi; // eslint-disable-line @typescript-eslint/no-explicit-any
     while (true) {
         const part = paramParts.shift();
         if (!part) {
             break;
         }
-        param = param[part];
+        foundObj = foundObj[part];
     }
-    return param;
+    return foundObj as T;
 }
 
 async function main() {
@@ -32,6 +36,7 @@ async function main() {
         operationId: string;
         requiredParams: boolean;
         tag: string;
+        hasResponseBody: boolean;
     }[] = [];
 
     const openapi = JSON.parse(specFile) as OpenAPIV3_1.Document;
@@ -44,13 +49,27 @@ async function main() {
             }
 
             let requiredParams = !!operation.requestBody;
+            let hasResponseBody = false;
+            for(const code in operation.responses) {
+                try {
+                    const httpCode = parseInt(code, 10);
+                    if (httpCode >= 200 && httpCode < 300) {
+                        const response = operation.responses[code];
+                        const responseObject = findObjectFromRef(response, openapi);
+                        if (responseObject.content) {
+                            for (const contentType in responseObject.content) {
+                                const content = responseObject.content[contentType];
+                                hasResponseBody = !!content.schema;
+                            }
+                        }
+                    }
+                } catch {
+                    continue;
+                }
+            }
 
             for (const param of operation.parameters || []) {
-                const ref = (param as OpenAPIV3_1.ReferenceObject).$ref as string | undefined;
-                let paramObject: OpenAPIV3_1.ParameterObject = param as OpenAPIV3_1.ParameterObject;
-                if (ref) {
-                    paramObject = findParamFromRef(ref, openapi);
-                }
+                const paramObject = findObjectFromRef(param, openapi);
                 if (paramObject.in === "path") {
                     requiredParams = true;
                 }
@@ -61,27 +80,41 @@ async function main() {
                 method: method.toUpperCase(),
                 operationId: operation.operationId || "",
                 requiredParams,
+                hasResponseBody,
                 tag: operation.tags[0],
             });
         }
     }
 
     const operationOutput = operations
         .map((operation) => {
-            const { operationId, method, path, requiredParams } = operation;
+            const { operationId, method, path, requiredParams, hasResponseBody } = operation;
             return `async ${operationId}(options${requiredParams ? "" : "?"}: FetchOptions<operations["${operationId}"]>) {
-    const { data } = await this.client.${method}("${path}", options);
-    return data;
-}
+    ${hasResponseBody ? `const { data } = ` : ``}await this.client.${method}("${path}", options);
+    ${hasResponseBody ? `return data;
+` : ``}}
 `;
         })
         .join("\n");
 
     const templateFile = (await fs.readFile(file, "utf8")) as string;
-    const output = templateFile.replace(
-        /\/\/ DO NOT EDIT\. This is auto-generated code\.\n.*\/\/ DO NOT EDIT\. This is auto-generated code\./g,
-        operationOutput
-    );
+    const templateLines = templateFile.split("\n");
+    let outputLines: string[] = [];
+    let addLines = true;
+    for(const line of templateLines) {
+        if (line.includes("DO NOT EDIT. This is auto-generated code.")) {
+            addLines = !addLines;
+            outputLines.push(line);
+            if (!addLines) {
+                outputLines.push(operationOutput);
+            }
+            continue;
+        }
+        if (addLines) {
+            outputLines.push(line);
+        }
+    }
+    const output = outputLines.join("\n");
 
     await fs.writeFile(file, output, "utf8");
 }

scripts/apply.ts

@@ -24,6 +24,7 @@ function filterOpenapi(openapi: OpenAPIV3_1.Document): OpenAPIV3_1.Document {
         "listClusters",
         "getCluster",
         "createCluster",
+        "deleteCluster",
         "listClustersForAllProjects",
         "createDatabaseUser",
         "listDatabaseUsers",

scripts/filter.ts

@@ -3,7 +3,7 @@
 set -Eeou pipefail
 
 curl -Lo ./scripts/spec.json https://github.com/mongodb/openapi/raw/refs/heads/main/openapi/v2/openapi-2025-03-12.json
-tsx ./scripts/filter.ts > ./scripts/filteredSpec.json < ./scripts/spec.json
+tsx --debug-port 5858 ./scripts/filter.ts > ./scripts/filteredSpec.json < ./scripts/spec.json
 redocly bundle --ext json --remove-unused-components ./scripts/filteredSpec.json --output ./scripts/bundledSpec.json
 openapi-typescript ./scripts/bundledSpec.json --root-types-no-schema-prefix --root-types --output ./src/common/atlas/openapi.d.ts
 tsx ./scripts/apply.ts --spec ./scripts/bundledSpec.json --file ./src/common/atlas/apiClient.ts

scripts/generate.sh

@@ -157,6 +157,10 @@ export class ApiClient {
         return data;
     }
 
+    async deleteCluster(options: FetchOptions<operations["deleteCluster"]>) {
+        await this.client.DELETE("/api/atlas/v2/groups/{groupId}/clusters/{clusterName}", options);
+    }
+
     async getCluster(options: FetchOptions<operations["getCluster"]>) {
         const { data } = await this.client.GET("/api/atlas/v2/groups/{groupId}/clusters/{clusterName}", options);
         return data;
@@ -171,5 +175,6 @@ export class ApiClient {
         const { data } = await this.client.POST("/api/atlas/v2/groups/{groupId}/databaseUsers", options);
         return data;
     }
+
     // DO NOT EDIT. This is auto-generated code.
 }