chore: enable eslint rule for consistent type import/export MCP-130 (#470)

Author: himanshusinghs

eslint.config.js

@@ -48,6 +48,13 @@ export default defineConfig([
         rules: {
             "@typescript-eslint/switch-exhaustiveness-check": "error",
             "@typescript-eslint/no-non-null-assertion": "error",
+            "@typescript-eslint/consistent-type-imports": ["error", { prefer: "type-imports" }],
+            "@typescript-eslint/consistent-type-exports": [
+                "error",
+                {
+                    fixMixedExportsWithInlineTypeSpecifier: false,
+                },
+            ],
             eqeqeq: "error",
             "no-self-compare": "error",
             "no-unassigned-vars": "error",

scripts/accuracy/generateTestSummary.ts

@@ -1,7 +1,7 @@
 import path from "path";
 import { readFile, writeFile, mkdir } from "fs/promises";
 import { getAccuracyResultStorage } from "../../tests/accuracy/sdk/accuracyResultStorage/getAccuracyResultStorage.js";
-import {
+import type {
     AccuracyResult,
     AccuracyRunStatuses,
     ExpectedToolCall,

scripts/apply.ts

@@ -1,5 +1,5 @@
 import fs from "fs/promises";
-import { OpenAPIV3_1 } from "openapi-types";
+import type { OpenAPIV3_1 } from "openapi-types";
 import argv from "yargs-parser";
 
 function findObjectFromRef<T>(obj: T | OpenAPIV3_1.ReferenceObject, openapi: OpenAPIV3_1.Document): T {

scripts/filter.ts

@@ -1,4 +1,4 @@
-import { OpenAPIV3_1 } from "openapi-types";
+import type { OpenAPIV3_1 } from "openapi-types";
 
 async function readStdin(): Promise<string> {
     return new Promise<string>((resolve, reject) => {

src/common/atlas/accessListUtils.ts

@@ -1,4 +1,4 @@
-import { ApiClient } from "./apiClient.js";
+import type { ApiClient } from "./apiClient.js";
 import { LogId } from "../logger.js";
 import { ApiClientError } from "./apiClientError.js";
 

src/common/atlas/apiClient.ts

@@ -1,10 +1,11 @@
-import createClient, { Client, Middleware } from "openapi-fetch";
-import type { ClientOptions, FetchOptions } from "openapi-fetch";
+import createClient from "openapi-fetch";
+import type { ClientOptions, FetchOptions, Client, Middleware } from "openapi-fetch";
 import { ApiClientError } from "./apiClientError.js";
-import { paths, operations } from "./openapi.js";
-import { CommonProperties, TelemetryEvent } from "../../telemetry/types.js";
+import type { paths, operations } from "./openapi.js";
+import type { CommonProperties, TelemetryEvent } from "../../telemetry/types.js";
 import { packageInfo } from "../packageInfo.js";
-import { LoggerBase, LogId } from "../logger.js";
+import type { LoggerBase } from "../logger.js";
+import { LogId } from "../logger.js";
 import { createFetch } from "@mongodb-js/devtools-proxy-support";
 import * as oauth from "oauth4webapi";
 import { Request as NodeFetchRequest } from "node-fetch";

src/common/atlas/apiClientError.ts

@@ -1,4 +1,4 @@
-import { ApiError } from "./openapi.js";
+import type { ApiError } from "./openapi.js";
 
 export class ApiClientError extends Error {
     private constructor(

src/common/atlas/cluster.ts

@@ -1,5 +1,5 @@
-import { ClusterDescription20240805, FlexClusterDescription20241113 } from "./openapi.js";
-import { ApiClient } from "./apiClient.js";
+import type { ClusterDescription20240805, FlexClusterDescription20241113 } from "./openapi.js";
+import type { ApiClient } from "./apiClient.js";
 import { LogId } from "../logger.js";
 
 export interface Cluster {

src/common/connectionManager.ts

@@ -1,15 +1,17 @@
-import { UserConfig, DriverOptions } from "./config.js";
+import type { UserConfig, DriverOptions } from "./config.js";
 import { NodeDriverServiceProvider } from "@mongosh/service-provider-node-driver";
 import EventEmitter from "events";
 import { setAppNameParamIfMissing } from "../helpers/connectionOptions.js";
 import { packageInfo } from "./packageInfo.js";
 import ConnectionString from "mongodb-connection-string-url";
-import { MongoClientOptions } from "mongodb";
+import type { MongoClientOptions } from "mongodb";
 import { ErrorCodes, MongoDBError } from "./errors.js";
-import { DeviceId } from "../helpers/deviceId.js";
-import { AppNameComponents } from "../helpers/connectionOptions.js";
-import { CompositeLogger, LogId } from "./logger.js";
-import { ConnectionInfo, generateConnectionInfoFromCliArgs } from "@mongosh/arg-parser";
+import type { DeviceId } from "../helpers/deviceId.js";
+import type { AppNameComponents } from "../helpers/connectionOptions.js";
+import type { CompositeLogger } from "./logger.js";
+import { LogId } from "./logger.js";
+import type { ConnectionInfo } from "@mongosh/arg-parser";
+import { generateConnectionInfoFromCliArgs } from "@mongosh/arg-parser";
 
 export interface AtlasClusterConnectionInfo {
     username: string;

src/common/exportsManager.ts

@@ -3,14 +3,16 @@ import path from "path";
 import fs from "fs/promises";
 import EventEmitter from "events";
 import { createWriteStream } from "fs";
-import { AggregationCursor, FindCursor } from "mongodb";
-import { EJSON, EJSONOptions, ObjectId } from "bson";
+import type { AggregationCursor, FindCursor } from "mongodb";
+import type { EJSONOptions } from "bson";
+import { EJSON, ObjectId } from "bson";
 import { Transform } from "stream";
 import { pipeline } from "stream/promises";
-import { MongoLogId } from "mongodb-log-writer";
+import type { MongoLogId } from "mongodb-log-writer";
 
-import { UserConfig } from "./config.js";
-import { LoggerBase, LogId } from "./logger.js";
+import type { UserConfig } from "./config.js";
+import type { LoggerBase } from "./logger.js";
+import { LogId } from "./logger.js";
 
 export const jsonExportFormat = z.enum(["relaxed", "canonical"]);
 export type JSONExportFormat = z.infer<typeof jsonExportFormat>;