chore: changeState does not have to be public

Author: himanshusinghs

src/common/connectionManager.ts

@@ -68,6 +68,18 @@ export interface ConnectionManagerEvents {
     "connection-errored": [ConnectionStateErrored];
 }
 
+/**
+ * For a few tests, we need the changeState method to force a connection state
+ * which is we have this type to typecast the actual ConnectionManager with
+ * public changeState (only to make TS happy).
+ */
+export type TestConnectionManager = ConnectionManager & {
+    changeState<Event extends keyof ConnectionManagerEvents, State extends ConnectionManagerEvents[Event][0]>(
+        event: Event,
+        newState: State
+    ): State;
+};
+
 export abstract class ConnectionManager {
     protected clientName: string = "unknown";
 
@@ -80,7 +92,7 @@ export abstract class ConnectionManager {
         return this.state;
     }
 
-    changeState<Event extends keyof ConnectionManagerEvents, State extends ConnectionManagerEvents[Event][0]>(
+    protected changeState<Event extends keyof ConnectionManagerEvents, State extends ConnectionManagerEvents[Event][0]>(
         event: Event,
         newState: State
     ): State {

tests/integration/common/connectionManager.oidc.test.ts

@@ -5,7 +5,11 @@ import process from "process";
 import type { MongoDBIntegrationTestCase } from "../tools/mongodb/mongodbHelpers.js";
 import { describeWithMongoDB, isCommunityServer, getServerVersion } from "../tools/mongodb/mongodbHelpers.js";
 import { defaultTestConfig, responseAsText, timeout, waitUntil } from "../helpers.js";
-import type { ConnectionStateConnected, ConnectionStateConnecting } from "../../../src/common/connectionManager.js";
+import type {
+    ConnectionStateConnected,
+    ConnectionStateConnecting,
+    TestConnectionManager,
+} from "../../../src/common/connectionManager.js";
 import type { UserConfig } from "../../../src/common/config.js";
 import { setupDriverConfig } from "../../../src/common/config.js";
 import path from "path";
@@ -122,7 +126,8 @@ describe.skipIf(process.platform !== "linux")("ConnectionManager OIDC Tests", as
                 }
 
                 beforeEach(async () => {
-                    const connectionManager = integration.mcpServer().session.connectionManager;
+                    const connectionManager = integration.mcpServer().session
+                        .connectionManager as TestConnectionManager;
                     // disconnect on purpose doesn't change the state if it was failed to avoid losing
                     // information in production.
                     await connectionManager.disconnect();

tests/integration/common/connectionManager.test.ts

@@ -1,17 +1,17 @@
 import type {
-    ConnectionManager,
     ConnectionManagerEvents,
     ConnectionStateConnected,
     ConnectionStringAuthType,
+    TestConnectionManager,
 } from "../../../src/common/connectionManager.js";
 import { MCPConnectionManager } from "../../../src/common/connectionManager.js";
 import type { UserConfig } from "../../../src/common/config.js";
 import { describeWithMongoDB } from "../tools/mongodb/mongodbHelpers.js";
 import { describe, beforeEach, expect, it, vi, afterEach } from "vitest";
 
 describeWithMongoDB("Connection Manager", (integration) => {
-    function connectionManager(): ConnectionManager {
-        return integration.mcpServer().session.connectionManager;
+    function connectionManager(): TestConnectionManager {
+        return integration.mcpServer().session.connectionManager as TestConnectionManager;
     }
 
     afterEach(async () => {