allow fileName option with fromString #294
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bumping this, I would really love to get off of a fork. Are there any reasons against inclusion here? |
|
+1 for this one, would really like to see this functionality |
|
@mishoo what's the status of this? seems quite a small change to deliberate on 1½ years :) |
|
Currently sourcemaps are broken without this feature when they are generated from the js API. Would really help to get this merged! |
|
+1 |
|
This is probably outdated, so I'm closing this PR. Feel free to re-submit if you think it should be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to enable source maps support.