fallback login strategy when no valid IDP found

harshavardhana · harshavardhana · commit d3feae249b12 · 2023-12-24T01:42:37.000-08:00
diff --git a/restapi/user_login.go b/restapi/user_login.go
@@ -230,7 +230,8 @@ func getLoginDetailsResponse(params authApi.LoginDetailParams, openIDProviders o
 	}
 
 	if len(openIDProviders) > 0 && len(redirectRules) == 0 {
-		return nil, ErrorWithContext(ctx, errors.New(403, "no reachable or configured IDP found, login not allowed"), ErrOauth2Provider)
+		loginStrategy = models.LoginDetailsLoginStrategyForm
+		// No IDP configured fallback to username/password
 	}
 
 	loginDetails = &models.LoginDetails{

Original file line number	Diff line number	Diff line change
`@@ -230,7 +230,8 @@ func getLoginDetailsResponse(params authApi.LoginDetailParams, openIDProviders o`
`230`	`230`	`}`
`231`	`231`
`232`	`232`	`if len(openIDProviders) > 0 && len(redirectRules) == 0 {`
`233`		`- return nil, ErrorWithContext(ctx, errors.New(403, "no reachable or configured IDP found, login not allowed"), ErrOauth2Provider)`
	`233`	`+ loginStrategy = models.LoginDetailsLoginStrategyForm`
	`234`	`+ // No IDP configured fallback to username/password`
`234`	`235`	`}`
`235`	`236`
`236`	`237`	`loginDetails = &models.LoginDetails{`