Skip to content

Commit a2180e1

Browse files
bexsoftBenjamin Perez
andauthored
Removed warnings on console (#345)
For Operator modules this will be removed after upgrading component to use redux/formik Co-authored-by: Benjamin Perez <[email protected]>
1 parent 0325bb7 commit a2180e1

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+183
-303
lines changed

portal-ui/bindata_assetfs.go

Lines changed: 97 additions & 97 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

portal-ui/src/Routes.tsx

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,10 @@
1515
// along with this program. If not, see <http://www.gnu.org/licenses/>.
1616

1717
import React from "react";
18-
import {
19-
Redirect,
20-
Route,
21-
Router,
22-
Switch,
23-
BrowserRouter,
24-
} from "react-router-dom";
18+
import { Redirect, Route, Router, Switch } from "react-router-dom";
2519
import history from "./history";
2620
import Login from "./screens/LoginPage/LoginPage";
2721
import Console from "./screens/Console/Console";
28-
import NotFoundPage from "./screens/NotFoundPage";
2922
import storage from "local-storage-fallback";
3023
import { connect } from "react-redux";
3124
import { AppState } from "./store";

portal-ui/src/common/utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
// along with this program. If not, see <http://www.gnu.org/licenses/>.
1616

1717
import storage from "local-storage-fallback";
18-
import { ICapacity, IStorageType, IZoneModel } from "./types";
18+
import { ICapacity, IZoneModel } from "./types";
1919

2020
const minStReq = 1073741824; // Minimal Space required for MinIO
2121
const minMemReq = 2147483648; // Minimal Memory required for MinIO in bytes

portal-ui/src/screens/Console/Buckets/ListBuckets/AddBucket.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import { modalBasic } from "../../Common/FormComponents/common/styleLibrary";
2323
import api from "../../../../common/api";
2424
import ModalWrapper from "../../Common/ModalWrapper/ModalWrapper";
2525
import InputBoxWrapper from "../../Common/FormComponents/InputBoxWrapper/InputBoxWrapper";
26-
import CheckboxWrapper from "../../Common/FormComponents/CheckboxWrapper/CheckboxWrapper";
2726
import SelectWrapper from "../../Common/FormComponents/SelectWrapper/SelectWrapper";
2827
import { factorForDropdown, getBytes } from "../../../../common/utils";
2928
import { AppState } from "../../../../store";
@@ -143,7 +142,7 @@ const AddBucket = ({
143142

144143
useEffect(() => {
145144
addBucketName(value);
146-
}, [value]);
145+
}, [value, addBucketName]);
147146

148147
const resetForm = () => {
149148
setBName("");

portal-ui/src/screens/Console/Buckets/ListBuckets/ListBuckets.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import React, { useEffect, useState } from "react";
1818
import { createStyles, Theme, withStyles } from "@material-ui/core/styles";
1919
import Grid from "@material-ui/core/Grid";
2020
import { Button } from "@material-ui/core";
21-
import Typography from "@material-ui/core/Typography";
2221
import TextField from "@material-ui/core/TextField";
2322
import InputAdornment from "@material-ui/core/InputAdornment";
2423
import SearchIcon from "@material-ui/icons/Search";
@@ -93,7 +92,6 @@ const ListBuckets = ({
9392
const [totalRecords, setTotalRecords] = useState<number>(0);
9493
const [loading, setLoading] = useState<boolean>(false);
9594
const [error, setError] = useState<string>("");
96-
const [deleteError, setDeleteError] = useState<string>("");
9795
const [page, setPage] = useState<number>(0);
9896
const [rowsPerPage, setRowsPerPage] = useState<number>(10);
9997
const [deleteOpen, setDeleteOpen] = useState<boolean>(false);
@@ -219,6 +217,7 @@ const ListBuckets = ({
219217
)}
220218
<PageHeader label={"Buckets"} />
221219
<Grid container>
220+
{error !== "" && <span className={classes.error}>{error}</span>}
222221
<Grid item xs={12} className={classes.container}>
223222
<Grid item xs={12} className={classes.actionsTray}>
224223
<TextField

portal-ui/src/screens/Console/Buckets/ListBuckets/Objects/ListObjects/ListObjects.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -174,17 +174,17 @@ class ListObjects extends React.Component<
174174
xhr.withCredentials = false;
175175
xhr.onload = function (event) {
176176
// TODO: handle status
177-
if (xhr.status == 401 || xhr.status == 403) {
177+
if (xhr.status === 401 || xhr.status === 403) {
178178
listObjects.showSnackBarMessage(
179179
"An error occurred while uploading the file."
180180
);
181181
}
182-
if (xhr.status == 500) {
182+
if (xhr.status === 500) {
183183
listObjects.showSnackBarMessage(
184184
"An error occurred while uploading the file."
185185
);
186186
}
187-
if (xhr.status == 200) {
187+
if (xhr.status === 200) {
188188
listObjects.showSnackBarMessage("Object uploaded successfully.");
189189
listObjects.fetchRecords();
190190
}
@@ -228,7 +228,7 @@ class ListObjects extends React.Component<
228228
xhr.responseType = "blob";
229229

230230
xhr.onload = function (e) {
231-
if (this.status == 200) {
231+
if (this.status === 200) {
232232
var blob = new Blob([this.response], {
233233
type: "octet/stream",
234234
});

portal-ui/src/screens/Console/Buckets/ViewBucket/AddReplicationModal.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,14 @@
1414
// You should have received a copy of the GNU Affero General Public License
1515
// along with this program. If not, see <http://www.gnu.org/licenses/>.
1616

17-
import React, { useState, useEffect } from "react";
17+
import React, { useState } from "react";
1818
import get from "lodash/get";
1919
import ModalWrapper from "../../Common/ModalWrapper/ModalWrapper";
2020
import { createStyles, Theme, withStyles } from "@material-ui/core/styles";
2121
import { modalBasic } from "../../Common/FormComponents/common/styleLibrary";
2222
import Grid from "@material-ui/core/Grid";
2323
import Typography from "@material-ui/core/Typography";
2424
import InputBoxWrapper from "../../Common/FormComponents/InputBoxWrapper/InputBoxWrapper";
25-
import SelectWrapper from "../../Common/FormComponents/SelectWrapper/SelectWrapper";
2625
import { Button, LinearProgress } from "@material-ui/core";
2726
import api from "../../../../common/api";
2827
import { IRemoteBucket } from "../types";

portal-ui/src/screens/Console/Buckets/ViewBucket/SetAccessPolicy.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ class SetAccessPolicy extends React.Component<
9494
}
9595

9696
render() {
97-
const { classes, open, actualPolicy } = this.props;
97+
const { classes, open } = this.props;
9898
const { addLoading, addError, accessPolicy } = this.state;
9999
return (
100100
<ModalWrapper

portal-ui/src/screens/Console/Buckets/ViewBucket/ViewBucket.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,7 @@ import {
3434
BucketReplicationRuleDeleteMarker,
3535
BucketVersioning,
3636
} from "../types";
37-
import { Box, Button } from "@material-ui/core";
38-
import Typography from "@material-ui/core/Typography";
37+
import { Button } from "@material-ui/core";
3938
import SetAccessPolicy from "./SetAccessPolicy";
4039
import { MinTablePaginationActions } from "../../../../common/MinTablePaginationActions";
4140
import { CreateIcon } from "../../../../icons";
@@ -363,7 +362,6 @@ class ViewBucket extends React.Component<IViewBucketProps, IViewBucketState> {
363362
selectedEvent,
364363
bucketSize,
365364
loadingSize,
366-
replicationSet,
367365
openSetReplication,
368366
isVersioned,
369367
replicationRules,

portal-ui/src/screens/Console/Common/FormComponents/CSVMultiSelector/CSVMultiSelector.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,8 @@ const CSVMultiSelector = ({
105105
firstUpdate.current = false;
106106
return;
107107
}
108-
109108
debouncedOnChange();
109+
// eslint-disable-next-line react-hooks/exhaustive-deps
110110
}, [currentElements]);
111111

112112
// If the last input is not empty, we add a new one

0 commit comments

Comments
 (0)