fix: Aviod coping functions when init CollectionSchema (#2902)

See also: #2776

Signed-off-by: yangxuan <[email protected]>

Author: XuanYang-cn

pymilvus/orm/schema.py

@@ -100,15 +100,14 @@ def __init__(
         self._partition_key_field = None
         self._clustering_key_field = None
 
-        if functions is None:
-            functions = []
-
-        if not isinstance(functions, list):
-            raise FunctionsTypeException(message=ExceptionsMessage.FunctionsType)
-        for function in functions:
-            if not isinstance(function, Function):
-                raise SchemaNotReadyException(message=ExceptionsMessage.FunctionIncorrectType)
-        self._functions = [copy.deepcopy(function) for function in functions]
+        self._functions = []
+        if functions:
+            if not isinstance(functions, list):
+                raise FunctionsTypeException(message=ExceptionsMessage.FunctionsType)
+            for function in functions:
+                if not isinstance(function, Function):
+                    raise SchemaNotReadyException(message=ExceptionsMessage.FunctionIncorrectType)
+            self._functions = functions
 
         if not isinstance(fields, list):
             raise FieldsTypeException(message=ExceptionsMessage.FieldsType)
@@ -118,7 +117,6 @@ def __init__(
         self._fields = [copy.deepcopy(field) for field in fields]
 
         self._mark_output_fields()
-
         self._check_kwargs()
         if kwargs.get("check_fields", True):
             self._check_fields()

tests/test_schema.py

@@ -1,42 +1,41 @@
 import numpy
 import pytest
 
-from pymilvus import CollectionSchema, FieldSchema, DataType, MilvusException
+from pymilvus import CollectionSchema, FieldSchema, DataType
 from utils import *
 from pymilvus.orm import schema as s
 
 
+from pymilvus.orm.schema import Function, FunctionType
+
 class TestCollectionSchema:
     @pytest.fixture(scope="function")
     def raw_dict(self):
-        _dict = {}
-        _dict["description"] = "TestCollectionSchema_description"
-        fields = [
-            {
-                "name": "vec1",
-                "description": "desc1",
-                "type": DataType.FLOAT_VECTOR,
-                "params": {"dim": 128},
-            },
-
-            {
-                "name": "vec2",
-                "description": "desc2",
-                "type": DataType.BINARY_VECTOR,
-                "params": {"dim": 128},
-            },
-            {
-                "name": "ID",
-                "description": "ID",
-                "type": DataType.INT64,
-                "is_primary": True,
-                "auto_id": False
-            },
-        ]
-        _dict["fields"] = fields
-        _dict["enable_dynamic_field"] = True
-
-        return _dict
+        return {
+            "description": "TestCollectionSchema_description",
+            "enable_dynamic_field": True,
+            "fields": [
+                {
+                    "name": "vec1",
+                    "description": "desc1",
+                    "type": DataType.FLOAT_VECTOR,
+                    "params": {"dim": 128},
+                },
+                {
+                    "name": "vec2",
+                    "description": "desc2",
+                    "type": DataType.BINARY_VECTOR,
+                    "params": {"dim": 128},
+                },
+                {
+                    "name": "ID",
+                    "description": "ID",
+                    "type": DataType.INT64,
+                    "is_primary": True,
+                    "auto_id": False
+                },
+            ]
+        }
 
     def test_constructor_from_dict(self, raw_dict):
         schema = CollectionSchema.construct_from_dict(raw_dict)
@@ -54,6 +53,14 @@ def test_to_dict(self, raw_dict):
         assert target == raw_dict
         assert target is not raw_dict
 
+    def test_init_with_functions(self, raw_dict):
+        functions = [
+            Function("func1", FunctionType.BM25, ["field1"], ["field2"])
+        ]
+        schema = CollectionSchema.construct_from_dict(raw_dict)
+        schema_with_func = CollectionSchema(schema.fields, schema.description, functions=functions)
+        assert schema_with_func.functions == functions
+
 
 class TestFieldSchema:
     @pytest.fixture(scope="function")