Skip to content

fix: add login custom styles, removes style not in use #2587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 7, 2023
Merged

fix: add login custom styles, removes style not in use #2587

merged 5 commits into from
Jul 7, 2023

Conversation

@Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Jul 4, 2023 •
edited
Loading

Closes #2567

PR Type

Bugfix

Description of the changes

Removes --login-popup-text-color token not in use
Adds custom tokens

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii requested a review from a team as a code owner July 4, 2023 13:35
@ghost
Copy link

ghost commented Jul 4, 2023

Thank you for creating a Pull Request @Mnickii.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

The updated storybook is available here

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

The updated storybook is available here

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

The updated storybook is available here

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

The updated storybook is available here

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

The updated storybook is available here

@gavinbarron gavinbarron enabled auto-merge (squash) July 7, 2023 23:22
@gavinbarron gavinbarron merged commit 7ba98e4 into main Jul 7, 2023
@gavinbarron gavinbarron deleted the bug-2567 branch July 7, 2023 23:26
This was referenced Jul 17, 2023
Closed
Closed
Merged
gavinbarron added a commit that referenced this pull request Aug 21, 2023
@Mnickii @gavinbarron
fix: add login custom styles, removes style not in use (#2587)
1125bb0 
* remove style not in use, add custom styling tokens

* fix account-item hover

---------

Co-authored-by: Gavin Barron <[email protected]>
@gavinbarron gavinbarron mentioned this pull request Oct 10, 2023
Merged
@gavinbarron gavinbarron mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@musale musale musale approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Build: Storybook

Projects

Graph Toolkit
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] --login-popup-text-color is missing from mgt-login

4 participants

@Mnickii @musale @gavinbarron