Skip to content

fix: announce more options button on narrator in mgt-tasks #2399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 16, 2023
Merged

fix: announce more options button on narrator in mgt-tasks #2399

merged 12 commits into from
Jun 16, 2023

Conversation

@Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Jun 5, 2023 •
edited
Loading

Closes #2290
Closes #2306

PR Type

Bugfix

Description of the changes

Adds aria-label to dot options in mgt-tasks to announce the More options button on narrator.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii requested a review from a team as a code owner June 5, 2023 14:33
@ghost
Copy link

ghost commented Jun 5, 2023

Thank you for creating a Pull Request @Mnickii.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@Mnickii
Copy link
Collaborator Author

Mnickii commented Jun 5, 2023

@vagpt and @KarunaNarang this item is ready for review.

@Mnickii Mnickii linked an issue Jun 5, 2023 that may be closed by this pull request
[MGTP- Mgt-tasks - tasks]: Name is not defined for the 'More Option' button present on the added tasks. #2290
Closed
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

The updated storybook is available here

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

The updated storybook is available here

musale
musale previously approved these changes Jun 5, 2023
View reviewed changes
gavinbarron
gavinbarron previously approved these changes Jun 5, 2023
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

The updated storybook is available here

@gavinbarron gavinbarron enabled auto-merge (squash) June 6, 2023 14:16
@gavinbarron gavinbarron disabled auto-merge June 6, 2023 14:16
@Mnickii Mnickii added this to the v3.1.0 milestone Jun 7, 2023
@Mnickii Mnickii linked an issue Jun 7, 2023 that may be closed by this pull request
[MGTP-Samples-General-Localization]: Name is not defined for 'More options' button under 'Localization' page. #2306
Closed
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

The updated storybook is available here

@vagpt
Copy link
Collaborator

vagpt commented Jun 7, 2023

@Mnickii and @gavinbarron

This issue is partially fixed as of now it is announcing the name but instead of button it is announcing as 'Group'. Please refer to the attached video below for reference.

Test Environment:
URL: https://mgt.dev/next/pr/2399/?path=/story/components-mgt-tasks--tasks
OS Version: 23H2(OS Build 25375.1)
Browser Version: Version 115.0.1880.3 (Official build) dev (64-bit)
Screen Reader: Narrator

Attachment:

Issue.is.partially.fix.mp4

@Mnickii Mnickii dismissed stale reviews from musale and gavinbarron via 598554d June 8, 2023 12:06
@Mnickii Mnickii requested review from gavinbarron and musale June 8, 2023 12:07
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

The updated storybook is available here

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

The updated storybook is available here

@Mnickii Mnickii requested a review from vagpt June 8, 2023 13:52
@musale
Copy link
Contributor

musale commented Jun 9, 2023 •
edited
Loading

@Mnickii you need #2424 to fix the remaining issue. When you'll be resolving the conflicts, prefer the incoming changes.

@github-actions
Copy link

The updated storybook is available here

gavinbarron
gavinbarron reviewed Jun 12, 2023
View reviewed changes
Mnickii
Mnickii commented Jun 15, 2023
View reviewed changes
Mnickii
Mnickii commented Jun 15, 2023
View reviewed changes
Mnickii
Mnickii commented Jun 15, 2023
View reviewed changes
@Mnickii Mnickii requested a review from gavinbarron June 15, 2023 11:38
@Mnickii
Copy link
Collaborator Author

Mnickii commented Jun 15, 2023

@vagpt this is ready to review

@github-actions
Copy link

The updated storybook is available here

1 similar comment
@github-actions
Copy link

The updated storybook is available here

@github-actions
Copy link

The updated storybook is available here

@gavinbarron gavinbarron enabled auto-merge (squash) June 16, 2023 16:23
@gavinbarron gavinbarron merged commit 11ef91f into next/fluentui Jun 16, 2023
@gavinbarron gavinbarron deleted the ac11y-2290 branch June 16, 2023 16:31
@github-actions
Copy link

The updated storybook is available here

This was referenced Jul 17, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vagpt vagpt Awaiting requested review from vagpt

@gavinbarron gavinbarron Awaiting requested review from gavinbarron

1 more reviewer

@musale musale musale approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Build: Storybook

Projects

Graph Toolkit
Archived in project

Milestone

v3.1.0

5 participants

@Mnickii @vagpt @musale @gavinbarron