Skip to content

feat: Support for new component mgt-search-results #2047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 59 commits into from
May 2, 2023
Merged

feat: Support for new component mgt-search-results #2047

merged 59 commits into from
May 2, 2023

Conversation

@sebastienlevert
Copy link
Contributor

@sebastienlevert sebastienlevert commented Feb 20, 2023 •
edited
Loading

Closes #2180

PR Type

  • Feature

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Feb 20, 2023

Thank you for creating a Pull Request @sebastienlevert.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@github-actions
Copy link

The updated storybook is available here

@github-actions
Copy link

The updated storybook is available here

@github-actions
Copy link

The updated storybook is available here

@github-actions
Copy link

The updated storybook is available here

gavinbarron
gavinbarron requested changes Apr 12, 2023
View reviewed changes
@ghost ghost added the Needs: Author Feedback Issue needs response from issue author label Apr 12, 2023
@sebastienlevert sebastienlevert linked an issue Apr 13, 2023 that may be closed by this pull request
[New Component] mgt-search-results and mgt-search-box #2180
Closed
@ghost ghost removed the Needs: Author Feedback Issue needs response from issue author label Apr 13, 2023
@github-actions
Copy link

The updated storybook is available here

@github-actions
Copy link

github-actions bot commented May 1, 2023

The updated storybook is available here

gavinbarron
gavinbarron requested changes May 1, 2023
View reviewed changes
@ghost ghost added the Needs: Author Feedback Issue needs response from issue author label May 1, 2023
@ghost ghost removed the Needs: Author Feedback Issue needs response from issue author label May 2, 2023
@github-actions
Copy link

github-actions bot commented May 2, 2023

The updated storybook is available here

@github-actions
Copy link

github-actions bot commented May 2, 2023

The updated storybook is available here

gavinbarron
gavinbarron approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebastienlevert sebastienlevert merged commit 87e6c2f into next/fluentui May 2, 2023
@sebastienlevert sebastienlevert deleted the sebastienlevert/mgt-search branch May 2, 2023 18:58
@gavinbarron gavinbarron mentioned this pull request May 17, 2023
Closed
This was referenced Jul 17, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinbarron gavinbarron gavinbarron approved these changes

@Mnickii Mnickii Awaiting requested review from Mnickii

+1 more reviewer

@musale musale musale approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Build: Storybook

Projects

Graph Toolkit
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[New Component] mgt-search-results and mgt-search-box

4 participants

@sebastienlevert @gavinbarron @musale