Skip to content

Conversation

@gavinbarron
Copy link
Member

@gavinbarron gavinbarron commented Feb 2, 2023

Closes #2014
Closes #2015

PR Type

  • Bugfix

Description of the changes

Updates typescript and ts-node dependencies

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

Samples now start without error

@ghost
Copy link

ghost commented Feb 2, 2023

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@gavinbarron gavinbarron changed the base branch from main to next/fluentui February 2, 2023 01:36
@gavinbarron gavinbarron enabled auto-merge (squash) February 2, 2023 21:03
@gavinbarron gavinbarron merged commit 8170289 into next/fluentui Feb 14, 2023
@gavinbarron gavinbarron deleted the bug/node-proxy-sample branch February 14, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG] proxy-provider-node sample is broken

4 participants