Skip to content

Conversation

@nmtoblum
Copy link
Contributor

Closes #1980

PR Type

  • Feature
  • Code style update (formatting)

Description of the changes

  • Add a dedicated icon for BusinessPhone instead using the cellphone icon for both numbers. Used the "Phone" icon from FluentUI as a similar one is also used in the first-party contact card. Scaled the icon by defining width and height in the SVG according to the other icons.
  • Add title and aria attributes for contact parts. Also added a descriptive text for the "Copy to clipboard" button that is acting as a button.
  • Code formatting as required by prettier.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser) Chrome, Edge & Firefox
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • Accessibility tested and approved
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

I wasn't able to provide a story that shows both the business and mobile number in the compact view, as there is no mock user that has both numbers provided (at least I couldn't find one). However, the "Anonymous display" story shows both numbers in the full view.

This is my first PR top this project. Please let me know is something is wrong or missing.

Add title and aria attributes for contact parts.
Code formatting as required by prettier.
@ghost
Copy link

ghost commented Dec 14, 2022

Thank you for creating a Pull Request @nmtoblum.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@nmtoblum
Copy link
Contributor Author

@microsoft-github-policy-service agree company="netmedianer GmbH"

@gavinbarron
Copy link
Member

Thanks for this improvement to the person card @nmtoblum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mgt-person-card should visually distinguish between business and mobile number

2 participants