Skip to content

Commit a83686a

Browse files
committed
using the correct term
1 parent eee447c commit a83686a

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

src/cascadia/WindowsTerminal/AppHost.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ AppHost::AppHost() noexcept :
7979
_window->WindowActivated({ this, &AppHost::_WindowActivated });
8080
_window->HotkeyPressed({ this, &AppHost::_GlobalHotkeyPressed });
8181
_window->NotifyTrayIconPressed({ this, &AppHost::_HandleTrayIconPressed });
82-
_window->NotifyWindowMinimized({ this, &AppHost::_HandleWindowMinimized });
82+
_window->NotifyWindowHidden({ this, &AppHost::_HandleWindowHidden });
8383
_window->SetAlwaysOnTop(_logic.GetInitialAlwaysOnTop());
8484
_window->MakeWindow();
8585

@@ -93,6 +93,7 @@ AppHost::AppHost() noexcept :
9393
AppHost::~AppHost()
9494
{
9595
// destruction order is important for proper teardown here
96+
9697
_window = nullptr;
9798
_app.Close();
9899
_app = nullptr;
@@ -929,7 +930,7 @@ void AppHost::_HandleTrayIconPressed()
929930
_window->SummonWindow({});
930931
}
931932

932-
void AppHost::_HandleWindowMinimized()
933+
void AppHost::_HandleWindowHidden()
933934
{
934935
// TODO:
935936
// Scoping "minimize to tray" to only the quake window.

src/cascadia/WindowsTerminal/AppHost.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,5 +84,5 @@ class AppHost
8484

8585
void _UpdateTrayIcon();
8686
void _HandleTrayIconPressed();
87-
void _HandleWindowMinimized();
87+
void _HandleWindowHidden();
8888
};

src/cascadia/WindowsTerminal/IslandWindow.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,7 @@ long IslandWindow::_calculateTotalSize(const bool isWidth, const long clientSize
452452
{
453453
if (wparam == SIZE_MINIMIZED && _isQuakeWindow)
454454
{
455-
_NotifyWindowMinimizedHandlers();
455+
_NotifyWindowHiddenHandlers();
456456
ShowWindow(GetHandle(), SW_HIDE);
457457
return 0;
458458
}
@@ -1289,8 +1289,6 @@ void IslandWindow::_globalDismissWindow(const uint32_t dropdownDuration)
12891289
{
12901290
ShowWindow(_window.get(), SW_MINIMIZE);
12911291
}
1292-
1293-
_NotifyWindowMinimizedHandlers();
12941292
}
12951293

12961294
// Method Description:

src/cascadia/WindowsTerminal/IslandWindow.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class IslandWindow :
5252
WINRT_CALLBACK(WindowActivated, winrt::delegate<void()>);
5353
WINRT_CALLBACK(HotkeyPressed, winrt::delegate<void(long)>);
5454
WINRT_CALLBACK(NotifyTrayIconPressed, winrt::delegate<void()>);
55-
WINRT_CALLBACK(NotifyWindowMinimized, winrt::delegate<void()>);
55+
WINRT_CALLBACK(NotifyWindowHidden, winrt::delegate<void()>);
5656

5757
protected:
5858
void ForceResize()

0 commit comments

Comments
 (0)