Skip to content

Commit 0619af5

Browse files
authored
[0.72] Backport changes to help set platform versions in podspecs (#2044)
* updateIphoneOSDeploymentTarget -> updateOSDeploymentTarget (facebook#39570) Summary: While merging new commits into React Native macOS, I noticed facebook#39478 I would like to also set `MACOS_DEPLOYMENT_TARGET` in our fork, and thought this slight rename would be something I can do upstream [Internal] - updateIphoneOSDeploymentTarget -> updateOSDeploymentTarget Pull Request resolved: facebook#39570 Test Plan: CI should pass Reviewed By: NickGerleman Differential Revision: D49514693 Pulled By: ryancat fbshipit-source-id: b4dafb1f9736d2977510712652cb8097263c489d * min_ios_version_supported -> min_supported_versions (facebook#39310) Summary: One of the most common diffs we have in React Native macOS is simply extending the `platforms` key Inside every pod spec to include macOS. React Native tvOS does the same to add tvOS. In the future, React Native may support visionOS, at which point we do the same thing again. Let's define a `min_supported_versions` hash that can be overridden at one place that is extensible to more platforms, instead of just specifying `min_ios_version_supported`. Note: In doing this change, I have set it that `React-Hermes.podspec` doesn't build for macOS anymore. I think this is safe, since anyone using Hermes on macOS was probably using React Native macOS where we already have a diff to add macOS back? [IOS] [CHANGED] - Add min_supported_versions helper to cocoa pods scripts Pull Request resolved: facebook#39310 Test Plan: CI should pass. Reviewed By: NickGerleman Differential Revision: D49014109 Pulled By: dmytrorykun fbshipit-source-id: d44fc7b750c70cc263a2c89502c022a0db9a4771 * Set macOS deployment target
1 parent 0a07004 commit 0619af5

File tree

53 files changed

+80
-59
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+80
-59
lines changed

packages/react-native/Libraries/ActionSheetIOS/React-RCTActionSheet.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Pod::Spec.new do |s|
2424
s.documentation_url = "https://reactnative.dev/docs/actionsheetios"
2525
s.license = package["license"]
2626
s.author = "Meta Platforms, Inc. and its affiliates"
27-
s.platforms = { :ios => "12.4", :osx => "10.15" } # [macOS]
27+
s.platforms = min_supported_versions
2828
s.source = source
2929
s.source_files = "*.{m}"
3030
s.preserve_paths = "package.json", "LICENSE", "LICENSE-docs"

packages/react-native/Libraries/AppDelegate/React-RCTAppDelegate.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ Pod::Spec.new do |s|
6060
s.documentation_url = "https://reactnative.dev/docs/actionsheetios"
6161
s.license = package["license"]
6262
s.author = "Meta Platforms, Inc. and its affiliates"
63-
s.platforms = { :ios => "12.4", :osx => "10.15" } # [macOS]
63+
s.platforms = min_supported_versions
6464
s.source = source
6565
s.source_files = "**/*.{c,h,m,mm,S,cpp}"
6666

packages/react-native/Libraries/Blob/React-RCTBlob.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ Pod::Spec.new do |s|
3939
s.homepage = "https://reactnative.dev/"
4040
s.license = package["license"]
4141
s.author = "Meta Platforms, Inc. and its affiliates"
42-
s.platforms = { :ios => "12.4", :osx => "10.15" } # [macOS]
42+
s.platforms = min_supported_versions
4343
s.compiler_flags = folly_compiler_flags + ' -Wno-nullability-completeness'
4444
s.source = source
4545
s.source_files = "*.{h,m,mm}"

packages/react-native/Libraries/FBLazyVector/FBLazyVector.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Pod::Spec.new do |s|
2323
s.homepage = "https://reactnative.dev/"
2424
s.license = package["license"]
2525
s.author = "Meta Platforms, Inc. and its affiliates"
26-
s.platforms = { :ios => "12.4", :osx => "10.15" } # [macOS]
26+
s.platforms = min_supported_versions
2727
s.source = source
2828
s.source_files = "**/*.{c,h,m,mm,cpp}"
2929
s.header_dir = "FBLazyVector"

packages/react-native/Libraries/Image/React-RCTImage.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ Pod::Spec.new do |s|
4040
s.documentation_url = "https://reactnative.dev/docs/image"
4141
s.license = package["license"]
4242
s.author = "Meta Platforms, Inc. and its affiliates"
43-
s.platforms = { :ios => "12.4", :osx => "10.15" } # [macOS]
43+
s.platforms = min_supported_versions
4444
s.compiler_flags = folly_compiler_flags + ' -Wno-nullability-completeness'
4545
s.source = source
4646
s.source_files = "*.{m,mm}"

packages/react-native/Libraries/LinkingIOS/React-RCTLinking.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ Pod::Spec.new do |s|
4343
s.documentation_url = "https://reactnative.dev/docs/linking"
4444
s.license = package["license"]
4545
s.author = "Meta Platforms, Inc. and its affiliates"
46-
s.platforms = { :ios => "12.4", :osx => "10.15" } # [macOS]
46+
s.platforms = min_supported_versions
4747
s.compiler_flags = folly_compiler_flags + ' -Wno-nullability-completeness'
4848
s.source = source
4949
s.source_files = "*.{m,mm}"

packages/react-native/Libraries/NativeAnimation/React-RCTAnimation.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ Pod::Spec.new do |s|
3939
s.homepage = "https://reactnative.dev/"
4040
s.license = package["license"]
4141
s.author = "Meta Platforms, Inc. and its affiliates"
42-
s.platforms = { :ios => "12.4", :osx => "10.15" } # [macOS]
42+
s.platforms = min_supported_versions
4343
s.compiler_flags = folly_compiler_flags + ' -Wno-nullability-completeness'
4444
s.source = source
4545
s.source_files = "**/*.{h,m,mm}"

packages/react-native/Libraries/Network/React-RCTNetwork.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ Pod::Spec.new do |s|
4343
s.homepage = "https://reactnative.dev/"
4444
s.license = package["license"]
4545
s.author = "Meta Platforms, Inc. and its affiliates"
46-
s.platforms = { :ios => "12.4", :osx => "10.15" } # [macOS]
46+
s.platforms = min_supported_versions
4747
s.compiler_flags = folly_compiler_flags + ' -Wno-nullability-completeness'
4848
s.source = source
4949
s.source_files = "*.{m,mm}"

packages/react-native/Libraries/PushNotificationIOS/React-RCTPushNotification.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ Pod::Spec.new do |s|
4040
s.documentation_url = "https://reactnative.dev/docs/pushnotificationios"
4141
s.license = package["license"]
4242
s.author = "Meta Platforms, Inc. and its affiliates"
43-
s.platforms = { :ios => "12.4", :osx => "10.15" } # [macOS]
43+
s.platforms = min_supported_versions
4444
s.compiler_flags = folly_compiler_flags + ' -Wno-nullability-completeness'
4545
s.source = source
4646
s.source_files = "*.{m,mm}"

packages/react-native/Libraries/RCTRequired/RCTRequired.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Pod::Spec.new do |s|
2323
s.homepage = "https://reactnative.dev/"
2424
s.license = package["license"]
2525
s.author = "Meta Platforms, Inc. and its affiliates"
26-
s.platforms = { :ios => "12.4", :osx => "10.15" } # [macOS]
26+
s.platforms = min_supported_versions
2727
s.source = source
2828
s.source_files = "**/*.{c,h,m,mm,cpp}"
2929
s.header_dir = "RCTRequired"

0 commit comments

Comments
 (0)