Made PEP 728 (TypedDict with extra items) no longer experimental since it has been accepted by the SC. (#10804)

Author: erictraut

docs/features.md

@@ -35,7 +35,7 @@ Pyright supports [configuration files](configuration.md) that provide granular c
 * [PEP 698](https://www.python.org/dev/peps/pep-0698/) override decorator for static typing
 * [PEP 702](https://www.python.org/dev/peps/pep-0702/) marking deprecations
 * [PEP 705](https://www.python.org/dev/peps/pep-0705/) TypedDict: read-only items
-* [PEP 728](https://www.python.org/dev/peps/pep-0728/) (experimental) TypedDict with typed extra items
+* [PEP 728](https://www.python.org/dev/peps/pep-0728/) TypedDict with typed extra items
 * [PEP 742](https://www.python.org/dev/peps/pep-0742/) narrowing types with TypeIs
 * [PEP 746](https://www.python.org/dev/peps/pep-0746/) (experimental) type checking annotated metadata
 * [PEP 747](https://www.python.org/dev/peps/pep-0747/) (experimental) annotating type forms

packages/pyright-internal/src/analyzer/typeEvaluator.ts

@@ -17707,10 +17707,7 @@ export function createTypeEvaluator(
                             );
                         } else if (arg.d.name.d.value === 'total' && !constArgValue) {
                             classType.shared.flags |= ClassTypeFlags.CanOmitDictValues;
-                        } else if (
-                            arg.d.name.d.value === 'closed' &&
-                            AnalyzerNodeInfo.getFileInfo(node).diagnosticRuleSet.enableExperimentalFeatures
-                        ) {
+                        } else if (arg.d.name.d.value === 'closed') {
                             if (constArgValue) {
                                 classType.shared.flags |=
                                     ClassTypeFlags.TypedDictMarkedClosed | ClassTypeFlags.TypedDictEffectivelyClosed;
@@ -17734,10 +17731,7 @@ export function createTypeEvaluator(
 
                             sawClosedOrExtraItems = true;
                         }
-                    } else if (
-                        arg.d.name.d.value === 'extra_items' &&
-                        AnalyzerNodeInfo.getFileInfo(node).diagnosticRuleSet.enableExperimentalFeatures
-                    ) {
+                    } else if (arg.d.name.d.value === 'extra_items') {
                         // Record a reference to the expression but don't evaluate it yet.
                         // It may refer to the class itself.
                         classType.shared.typedDictExtraItemsExpr = arg.d.valueExpr;

packages/pyright-internal/src/analyzer/typedDicts.ts

@@ -206,10 +206,7 @@ export function createTypedDictType(
                     );
                 } else if (arg.name.d.value === 'total' && arg.valueExpression.d.constType === KeywordType.False) {
                     classType.shared.flags |= ClassTypeFlags.CanOmitDictValues;
-                } else if (
-                    arg.name.d.value === 'closed' &&
-                    AnalyzerNodeInfo.getFileInfo(errorNode).diagnosticRuleSet.enableExperimentalFeatures
-                ) {
+                } else if (arg.name.d.value === 'closed') {
                     if (arg.valueExpression.d.constType === KeywordType.True) {
                         classType.shared.flags |=
                             ClassTypeFlags.TypedDictMarkedClosed | ClassTypeFlags.TypedDictEffectivelyClosed;
@@ -225,10 +222,7 @@ export function createTypedDictType(
 
                     sawClosedOrExtraItems = true;
                 }
-            } else if (
-                arg.name?.d.value === 'extra_items' &&
-                AnalyzerNodeInfo.getFileInfo(errorNode).diagnosticRuleSet.enableExperimentalFeatures
-            ) {
+            } else if (arg.name?.d.value === 'extra_items') {
                 classType.shared.typedDictExtraItemsExpr = arg.valueExpression;
                 classType.shared.flags |= ClassTypeFlags.TypedDictEffectivelyClosed;
 

packages/pyright-internal/src/tests/typeEvaluator5.test.ts

@@ -339,96 +339,62 @@ test('TypeAliasType2', () => {
 });
 
 test('TypedDictReadOnly1', () => {
-    const configOptions = new ConfigOptions(Uri.empty());
-
-    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictReadOnly1.py'], configOptions);
+    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictReadOnly1.py']);
     TestUtils.validateResults(analysisResults, 4);
 });
 
 test('TypedDictReadOnly2', () => {
-    const configOptions = new ConfigOptions(Uri.empty());
-
-    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictReadOnly2.py'], configOptions);
+    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictReadOnly2.py']);
     TestUtils.validateResults(analysisResults, 17);
 });
 
 test('TypedDictClosed1', () => {
-    const configOptions = new ConfigOptions(Uri.empty());
-    configOptions.diagnosticRuleSet.enableExperimentalFeatures = true;
-
-    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictClosed1.py'], configOptions);
+    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictClosed1.py']);
     TestUtils.validateResults(analysisResults, 7);
 });
 
 test('TypedDictClosed2', () => {
-    const configOptions = new ConfigOptions(Uri.empty());
-    configOptions.diagnosticRuleSet.enableExperimentalFeatures = true;
-
-    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictClosed2.py'], configOptions);
+    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictClosed2.py']);
     TestUtils.validateResults(analysisResults, 4);
 });
 
 test('TypedDictClosed3', () => {
-    const configOptions = new ConfigOptions(Uri.empty());
-    configOptions.diagnosticRuleSet.enableExperimentalFeatures = true;
-
-    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictClosed3.py'], configOptions);
+    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictClosed3.py']);
     TestUtils.validateResults(analysisResults, 10);
 });
 
 test('TypedDictClosed4', () => {
-    const configOptions = new ConfigOptions(Uri.empty());
-    configOptions.diagnosticRuleSet.enableExperimentalFeatures = true;
-
-    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictClosed4.py'], configOptions);
+    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictClosed4.py']);
     TestUtils.validateResults(analysisResults, 5);
 });
 
 test('TypedDictClosed5', () => {
-    const configOptions = new ConfigOptions(Uri.empty());
-    configOptions.diagnosticRuleSet.enableExperimentalFeatures = true;
-
-    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictClosed5.py'], configOptions);
+    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictClosed5.py']);
     TestUtils.validateResults(analysisResults, 1);
 });
 
 test('TypedDictClosed6', () => {
-    const configOptions = new ConfigOptions(Uri.empty());
-    configOptions.diagnosticRuleSet.enableExperimentalFeatures = true;
-
-    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictClosed6.py'], configOptions);
+    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictClosed6.py']);
     TestUtils.validateResults(analysisResults, 8);
 });
 
 test('TypedDictClosed7', () => {
-    const configOptions = new ConfigOptions(Uri.empty());
-    configOptions.diagnosticRuleSet.enableExperimentalFeatures = true;
-
-    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictClosed7.py'], configOptions);
+    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictClosed7.py']);
     TestUtils.validateResults(analysisResults, 6);
 });
 
 test('TypedDictClosed8', () => {
-    const configOptions = new ConfigOptions(Uri.empty());
-    configOptions.diagnosticRuleSet.enableExperimentalFeatures = true;
-
-    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictClosed8.py'], configOptions);
+    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictClosed8.py']);
     TestUtils.validateResults(analysisResults, 0);
 });
 
 test('TypedDictClosed9', () => {
-    const configOptions = new ConfigOptions(Uri.empty());
-    configOptions.diagnosticRuleSet.enableExperimentalFeatures = true;
-
-    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictClosed9.py'], configOptions);
+    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictClosed9.py']);
     TestUtils.validateResults(analysisResults, 1);
 });
 
 test('TypedDictClosed10', () => {
-    const configOptions = new ConfigOptions(Uri.empty());
-    configOptions.diagnosticRuleSet.enableExperimentalFeatures = true;
-
-    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictClosed10.py'], configOptions);
+    const analysisResults = TestUtils.typeAnalyzeSampleFiles(['typedDictClosed10.py']);
     TestUtils.validateResults(analysisResults, 0);
 });