fix: [#4520] Upgrade restify to fix error on Node version 18+ (#4528)

* Upgrade restify in JS and TS generators

* Upgrade botbuilder version in generators

* Fix lint issue in core bot TS

Author: ceciliaavila

generators/generator-botbuilder/generators/app/templates/core/index.ts

@@ -14,7 +14,7 @@ import { INodeSocket } from 'botframework-streaming';
 
 // Import required bot services.
 // See https://aka.ms/bot-services to learn more about the different parts of a bot.
-import { 
+import {
     CloudAdapter,
     ConfigurationServiceClientCredentialFactory,
     ConversationState,

generators/generator-botbuilder/generators/app/templates/core/package-with-tests.json.js

@@ -17,12 +17,12 @@
     },
     "dependencies": {
         "@microsoft/recognizers-text-data-types-timex-expression": "1.1.4",
-        "botbuilder": "~4.15.0",
-        "botbuilder-ai": "~4.15.0",
-        "botbuilder-dialogs": "~4.15.0",
-        "botbuilder-testing": "~4.15.0",
+        "botbuilder": "~4.20.0",
+        "botbuilder-ai": "~4.20.0",
+        "botbuilder-dialogs": "~4.20.0",
+        "botbuilder-testing": "~4.20.0",
         "dotenv": "^8.2.0",
-        "restify": "^8.5.1"
+        "restify": "^11.1.0"
     },
     "devDependencies": {
         "eslint": "^7.0.0",

generators/generator-botbuilder/generators/app/templates/core/package-with-tests.json.ts

@@ -38,13 +38,13 @@
     },
     "dependencies": {
       "@microsoft/recognizers-text-data-types-timex-expression": "1.1.4",
-      "botbuilder": "~4.15.0",
-      "botbuilder-ai": "~4.15.0",
-      "botbuilder-dialogs": "~4.15.0",
-      "botbuilder-testing": "~4.15.0",
+      "botbuilder": "~4.20.0",
+      "botbuilder-ai": "~4.20.0",
+      "botbuilder-dialogs": "~4.20.0",
+      "botbuilder-testing": "~4.20.0",
       "dotenv": "^8.2.0",
       "replace": "~1.2.0",
-      "restify": "~8.5.1"
+      "restify": "~11.1.0"
 },
   "devDependencies": {
       "@types/mocha": "^7.0.2",

generators/generator-botbuilder/generators/app/templates/core/package.json.js

@@ -17,11 +17,11 @@
     },
     "dependencies": {
         "@microsoft/recognizers-text-data-types-timex-expression": "1.1.4",
-        "botbuilder": "~4.15.0",
-        "botbuilder-ai": "~4.15.0",
-        "botbuilder-dialogs": "~4.15.0",
+        "botbuilder": "~4.20.0",
+        "botbuilder-ai": "~4.20.0",
+        "botbuilder-dialogs": "~4.20.0",
         "dotenv": "~8.2.0",
-        "restify": "~10.0.0"
+        "restify": "~11.1.0"
     },
     "devDependencies": {
         "eslint": "^7.0.0",

generators/generator-botbuilder/generators/app/templates/core/package.json.ts

@@ -19,12 +19,12 @@
     },
     "dependencies": {
         "@microsoft/recognizers-text-data-types-timex-expression": "1.1.4",
-        "botbuilder": "~4.15.0",
-        "botbuilder-ai": "~4.15.0",
-        "botbuilder-dialogs": "~4.15.0",
+        "botbuilder": "~4.20.0",
+        "botbuilder-ai": "~4.20.0",
+        "botbuilder-dialogs": "~4.20.0",
         "dotenv": "~8.2.0",
         "replace": "~1.2.0",
-        "restify": "~8.5.1"
+        "restify": "~11.1.0"
     },
     "devDependencies": {
         "@types/mocha": "^7.0.2",

generators/generator-botbuilder/generators/app/templates/core/tsconfig.json

@@ -2,7 +2,7 @@
   "compilerOptions": {
     "composite": true,
     "declaration": true,
-    "target": "es2016",
+    "target": "es2017",
     "module": "commonjs",
     "outDir": "./lib",
     "rootDir": "./src",

generators/generator-botbuilder/generators/app/templates/echo/package.json.js

@@ -16,7 +16,7 @@
         "url": "https://github.com"
     },
     "dependencies": {
-        "botbuilder": "~4.15.0",
+        "botbuilder": "~4.20.0",
         "dotenv": "~8.2.0",
         "restify": "~11.1.0"
     },

generators/generator-botbuilder/generators/app/templates/echo/package.json.ts

@@ -18,10 +18,10 @@
         "url": "https://github.com"
     },
     "dependencies": {
-        "botbuilder": "~4.15.0",
+        "botbuilder": "~4.20.0",
         "dotenv": "~8.2.0",
         "replace": "~1.2.0",
-        "restify": "~8.5.1"
+        "restify": "~11.1.0"
     },
     "devDependencies": {
         "@types/restify": "8.4.2",

generators/generator-botbuilder/generators/app/templates/echo/tsconfig.json

@@ -1,7 +1,7 @@
 {
   "compilerOptions": {
     "declaration": true,
-    "target": "es2016",
+    "target": "es2017",
     "module": "commonjs",
     "outDir": "./lib",
     "rootDir": "./src",

generators/generator-botbuilder/generators/app/templates/empty/package.json.js

@@ -16,8 +16,8 @@
         "url": "https://github.com"
     },
     "dependencies": {
-        "botbuilder": "~4.15.0",
-        "restify": "~10.0.0"
+        "botbuilder": "~4.20.0",
+        "restify": "~11.1.0"
     },
     "devDependencies": {
         "eslint": "^7.0.0",