Remove getOrSetNodeChildren

Author: jakebailey

src/compiler/factory/nodeChildren.ts

@@ -8,20 +8,12 @@ export function getNodeChildren(node: Node): Node[] | undefined {
 }
 
 /** @internal */
-export function setNodeChildren(node: Node, children: Node[]) {
+export function setNodeChildren(node: Node, children: Node[]): Node[] {
     nodeChildren.set(node, children);
+    return children;
 }
 
 /** @internal */
 export function unsetNodeChildren(node: Node) {
     nodeChildren.delete(node);
 }
-
-/** @internal */
-export function getOrSetNodeChildren(node: Node, fn: () => Node[]): Node[] {
-    let children = getNodeChildren(node);
-    if (children === undefined) {
-        setNodeChildren(node, children = fn());
-    }
-    return children;
-}

src/services/services.ts

@@ -106,10 +106,10 @@ import {
     getNameFromPropertyName,
     getNewLineCharacter,
     getNewLineOrDefaultFromHost,
+    getNodeChildren,
     getNonAssignedNameOfDeclaration,
     getNormalizedAbsolutePath,
     getObjectFlags,
-    getOrSetNodeChildren,
     getQuotePreference,
     getScriptKind,
     getSetExternalModuleIndicator,
@@ -438,7 +438,7 @@ class NodeObject<TKind extends SyntaxKind> implements Node {
 
     public getChildren(sourceFile?: SourceFileLike): Node[] {
         this.assertHasRealPosition("Node without a real position cannot be scanned and thus has no token nodes - use forEachChild and collect the result if that's fine");
-        return getOrSetNodeChildren(this, () => createChildren(this, sourceFile));
+        return getNodeChildren(this) ?? setNodeChildren(this, createChildren(this, sourceFile));
     }
 
     public getFirstToken(sourceFile?: SourceFileLike): Node | undefined {