Merge pull request #15669 from Microsoft/simplify-js-check-in-index-constraint-errors

Simplify js check in index constraint errors

Author: sandersn

src/compiler/checker.ts

@@ -20361,7 +20361,7 @@ namespace ts {
                 // this allows to rule out cases when both property and indexer are inherited from the base class
                 let errorNode: Node;
                 if (propDeclaration &&
-                    (getSpecialPropertyAssignmentKind(propDeclaration as BinaryExpression) === SpecialPropertyAssignmentKind.ThisProperty ||
+                    (propDeclaration.kind === SyntaxKind.BinaryExpression ||
                      propDeclaration.name.kind === SyntaxKind.ComputedPropertyName ||
                      prop.parent === containingType.symbol)) {
                     errorNode = propDeclaration;

tests/baselines/reference/checkIndexConstraintOfJavascriptClassExpression.errors.txt

@@ -0,0 +1,29 @@
+tests/cases/compiler/weird.js(1,1): error TS2304: Cannot find name 'someFunction'.
+tests/cases/compiler/weird.js(1,23): error TS7006: Parameter 'BaseClass' implicitly has an 'any' type.
+tests/cases/compiler/weird.js(6,13): error TS2346: Supplied parameters do not match any signature of call target.
+tests/cases/compiler/weird.js(9,17): error TS7006: Parameter 'error' implicitly has an 'any' type.
+
+
+==== tests/cases/compiler/weird.js (4 errors) ====
+    someFunction(function(BaseClass) {
+    ~~~~~~~~~~~~
+!!! error TS2304: Cannot find name 'someFunction'.
+                          ~~~~~~~~~
+!!! error TS7006: Parameter 'BaseClass' implicitly has an 'any' type.
+        'use strict';
+        const DEFAULT_MESSAGE = "nop!";
+        class Hello extends BaseClass {
+            constructor() {
+                super();
+                ~~~~~~~
+!!! error TS2346: Supplied parameters do not match any signature of call target.
+                this.foo = "bar";
+            }
+            _render(error) {
+                    ~~~~~
+!!! error TS7006: Parameter 'error' implicitly has an 'any' type.
+                const message = error.message || DEFAULT_MESSAGE;
+            }
+        }
+    });
+    

tests/baselines/reference/checkIndexConstraintOfJavascriptClassExpression.js

@@ -1,10 +1,19 @@
 // @Filename: weird.js
 // @allowJs: true
+// @checkJs: true
+// @strict: true
+// @noEmit: true
 // @out: foo.js
 someFunction(function(BaseClass) {
-	class Hello extends BaseClass {
-		constructor() {
-			this.foo = "bar";
-		}
-	}
+    'use strict';
+    const DEFAULT_MESSAGE = "nop!";
+    class Hello extends BaseClass {
+        constructor() {
+            super();
+            this.foo = "bar";
+        }
+        _render(error) {
+            const message = error.message || DEFAULT_MESSAGE;
+        }
+    }
 });