Sort affectedFilesPendingEmit for consistent build info text

Author: sheetalkamat

src/compiler/builder.ts

@@ -757,10 +757,10 @@ namespace ts {
         if (state.affectedFilesPendingEmit) {
             const affectedFilesPendingEmit: ProgramBuilderInfoFilePendingEmit[] = [];
             const seenFiles = createMap<true>();
-            for (let i = state.affectedFilesPendingEmitIndex!; i < state.affectedFilesPendingEmit.length; i++) {
-                const path = state.affectedFilesPendingEmit[i];
-                if (!addToSeen(seenFiles, path)) continue;
-                affectedFilesPendingEmit.push([relativeToBuildInfo(path), state.affectedFilesPendingEmitKind!.get(path)!]);
+            for (const path of state.affectedFilesPendingEmit.slice(state.affectedFilesPendingEmitIndex).sort(compareStringsCaseSensitive)) {
+                if (addToSeen(seenFiles, path)) {
+                    affectedFilesPendingEmit.push([relativeToBuildInfo(path), state.affectedFilesPendingEmitKind!.get(path)!]);
+                }
             }
             result.affectedFilesPendingEmit = affectedFilesPendingEmit;
         }

src/testRunner/unittests/tsbuild/helpers.ts

@@ -302,9 +302,12 @@ interface Symbol {
                     // Verify that incrementally pending affected file emit are in clean build since clean build can contain more files compared to incremental depending of noEmitOnError option
                     if (actualAffectedFilesPendingEmit) {
                         assert.isDefined(expectedAffectedFilesPendingEmit, `Incremental build contains affectedFilesPendingEmit, clean build should also have it: ${outputFile}::\nIncremental buildInfoText:: ${actualText}\nClean buildInfoText:: ${expectedText}`);
-                        for (const actual of actualAffectedFilesPendingEmit) {
-                            assert.isTrue(contains(expectedAffectedFilesPendingEmit, actual, ([file1], [file2]) => file1 === file2), `Incremental build contains ${actual[0]} file as pending emit, clean build should also have it: ${outputFile}::\nIncremental buildInfoText:: ${actualText}\nClean buildInfoText:: ${expectedText}`);
-                        }
+                        let expectedIndex = 0;
+                        actualAffectedFilesPendingEmit.forEach(([actualFile]) => {
+                            expectedIndex = findIndex(expectedAffectedFilesPendingEmit!, ([expectedFile]) => actualFile === expectedFile, expectedIndex);
+                            assert.notEqual(expectedIndex, -1, `Incremental build contains ${actualFile} file as pending emit, clean build should also have it: ${outputFile}::\nIncremental buildInfoText:: ${actualText}\nClean buildInfoText:: ${expectedText}`);
+                            expectedIndex++;
+                        });
                     }
                 }
             }

tests/baselines/reference/tsbuild/inferredTypeFromTransitiveModule/initial-build/reports-errors-in-files-affected-by-change-in-signature-with-isolatedModules.js

@@ -347,16 +347,16 @@ exitCode:: ExitStatus.DiagnosticsPresent_OutputsSkipped
     ],
     "affectedFilesPendingEmit": [
       [
-        "../lazyindex.ts",
-        0
+        "../bar.ts",
+        1
       ],
       [
         "../index.ts",
         0
       ],
       [
-        "../bar.ts",
-        1
+        "../lazyindex.ts",
+        0
       ]
     ]
   },

tests/baselines/reference/tsbuild/sample1/initial-build/does-not-build-downstream-projects-if-upstream-projects-have-errors.js

@@ -260,11 +260,11 @@ exports.multiply = multiply;
     ],
     "affectedFilesPendingEmit": [
       [
-        "../core/index.d.ts",
+        "../core/anothermodule.d.ts",
         1
       ],
       [
-        "../core/anothermodule.d.ts",
+        "../core/index.d.ts",
         1
       ],
       [