fix another crash

Author: sandersn

src/services/codefixes/addOptionalPropertyUndefined.ts

@@ -87,11 +87,12 @@ namespace ts.codefix {
         else if (isVariableDeclaration(errorNode.parent) && errorNode.parent.initializer) {
             return { source: errorNode.parent.initializer, target: errorNode.parent.name };
         }
-        else if (isCallExpression(errorNode.parent) && errorNode.parent.arguments.indexOf(errorNode as Expression) > -1) {
+        else if (isCallExpression(errorNode.parent)) {
             const n = checker.getSymbolAtLocation(errorNode.parent.expression);
-            if (!n?.valueDeclaration) return undefined;
+            if (!n?.valueDeclaration || !isFunctionLikeKind(n.valueDeclaration.kind)) return undefined;
             if (!isExpression(errorNode)) return undefined;
             const i = errorNode.parent.arguments.indexOf(errorNode);
+            if (i === -1) return undefined;
             const name = (n.valueDeclaration as any as SignatureDeclaration).parameters[i].name;
             if (isIdentifier(name)) return { source: errorNode, target: name };
         }

tests/cases/fourslash/fixExactOptionalUnassignableProperties6.ts

@@ -5,7 +5,7 @@
 // @Filename: fixExactOptionalUnassignableProperties6.ts
 // based on snapshotterInjected.ts in microsoft/playwright
 //// type Data = {
-////     p?: boolean,
+////     p?: (x: number) => void,
 //// };
 //// declare function e(o: any): Data;
 //// e(101).p = undefined
@@ -18,7 +18,7 @@ verify.codeFix({
     index: 0,
     newFileContent:
 `type Data = {
-    p?: boolean | undefined,
+    p?: ((x: number) => void) | undefined,
 };
 declare function e(o: any): Data;
 e(101).p = undefined`,

tests/cases/fourslash/fixExactOptionalUnassignableProperties7.ts

@@ -0,0 +1,13 @@
+/// <reference path='fourslash.ts'/>
+
+// @strictNullChecks: true
+// @exactOptionalPropertyTypes: true
+// @Filename: fixExactOptionalUnassignableProperties6.ts
+// based on snapshotterInjected.ts in microsoft/playwright
+//// class Feh {
+////     _requestFinished(error?: string) {
+////         this._finishedPromiseCallback({ error/**/ });
+////     }
+////     private _finishedPromiseCallback: (arg: { error?: string }) => void = () => {};
+//// }
+verify.codeFixAvailable([ ]);