Merge pull request #1510 from microsoft/save_jsx_params_before_reload

Orta Therox · web-flow · commit 31832acc49a6 · 2021-01-21T12:56:58.000Z
Save the JSX params before a reload
diff --git a/packages/playground/src/createConfigDropdown.ts b/packages/playground/src/createConfigDropdown.ts
@@ -98,6 +98,8 @@ export const createConfigDropdown = (sandbox: Sandbox, monaco: Monaco) => {
     const isNowJSX = internalSwitch.selectedIndex !== 0
     const isJSX = sandbox.filepath.endsWith("x")
     if (isNowJSX !== isJSX) {
+      const newURL = sandbox.createURLQueryWithCompilerOptions(sandbox)
+      window.history.replaceState({}, "", newURL)
       setTimeout(() => document.location.reload(), 300)
     }
   })
diff --git a/packages/typescriptlang-org/src/pages/dev/bug-workbench.tsx b/packages/typescriptlang-org/src/pages/dev/bug-workbench.tsx
@@ -111,6 +111,7 @@ const Play: React.FC<Props> = (props) => {
             dtsMap = defaultMap
             runTwoslash()
           })
+
         }
 
         // When the compiler notices a twoslash compiler flag change, this will get triggered and reset the DTS map

Original file line number	Diff line number	Diff line change
`@@ -98,6 +98,8 @@ export const createConfigDropdown = (sandbox: Sandbox, monaco: Monaco) => {`
`98`	`98`	`const isNowJSX = internalSwitch.selectedIndex !== 0`
`99`	`99`	`const isJSX = sandbox.filepath.endsWith("x")`
`100`	`100`	`if (isNowJSX !== isJSX) {`
	`101`	`+ const newURL = sandbox.createURLQueryWithCompilerOptions(sandbox)`
	`102`	`+ window.history.replaceState({}, "", newURL)`
`101`	`103`	`setTimeout(() => document.location.reload(), 300)`
`102`	`104`	`}`
`103`	`105`	`})`
Original file line number	Diff line number	Diff line change
`@@ -111,6 +111,7 @@ const Play: React.FC<Props> = (props) => {`
`111`	`111`	`dtsMap = defaultMap`
`112`	`112`	`runTwoslash()`
`113`	`113`	`})`
	`114`	`+`
`114`	`115`	`}`
`115`	`116`
`116`	`117`	`// When the compiler notices a twoslash compiler flag change, this will get triggered and reset the DTS map`