Apply suggestions from code review

baywet · web-flow · commit b3224c457fe1 · 2023-10-24T15:14:45.000-04:00
diff --git a/src/Microsoft.OpenApi.Readers/Services/OpenApiRemoteReferenceCollector.cs b/src/Microsoft.OpenApi.Readers/Services/OpenApiRemoteReferenceCollector.cs
@@ -39,10 +39,9 @@ public override void Visit(IOpenApiReferenceable referenceable)
         /// </summary>
         private void AddReference(OpenApiReference reference)
         {
-            if (reference is {IsExternal: true} &&
-                !_references.ContainsKey(reference.ExternalResource))
+            if (reference is {IsExternal: true})
             {
-                _references.Add(reference.ExternalResource, reference);
+                _references.TryAdd(reference.ExternalResource, reference);
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -39,10 +39,9 @@ public override void Visit(IOpenApiReferenceable referenceable)`
`39`	`39`	`/// </summary>`
`40`	`40`	`private void AddReference(OpenApiReference reference)`
`41`	`41`	`{`
`42`		`- if (reference is {IsExternal: true} &&`
`43`		`- !_references.ContainsKey(reference.ExternalResource))`
	`42`	`+ if (reference is {IsExternal: true})`
`44`	`43`	`{`
`45`		`- _references.Add(reference.ExternalResource, reference);`
	`44`	`+ _references.TryAdd(reference.ExternalResource, reference);`
`46`	`45`	`}`
`47`	`46`	`}`
`48`	`47`	`}`