- code review feedback implementation

Signed-off-by: Vincent Biret <[email protected]>

Author: baywet

src/Microsoft.OpenApi.OData.Reader/Common/StringExtensions.cs

@@ -5,6 +5,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using Microsoft.OpenApi.OData.Vocabulary;
 
 namespace Microsoft.OpenApi.OData.Common
@@ -106,5 +107,13 @@ internal static string CheckArgumentNullOrEmpty(string value, string parameterNa
 
             return value;
         }
+
+        /// <summary>
+        /// Lowers the first character of the string.
+        /// </summary>
+        /// <param name="input">The input string.</param>
+        /// <returns>The changed string.</returns>
+        internal static string ToFirstCharacterLowerCase(this string input)
+            => string.IsNullOrEmpty(input) ? input : $"{char.ToLowerInvariant(input.FirstOrDefault())}{input.Substring(1)}";
     }
 }

src/Microsoft.OpenApi.OData.Reader/Common/Utils.cs

@@ -22,14 +22,17 @@ internal class OpenApiEnumValuesDescriptionExtension : IOpenApiExtension
     /// Name of the extension as used in the description.
     /// </summary>
 	public string Name => "x-ms-enum";
+
 	/// <summary>
 	/// The of the enum.
 	/// </summary>
 	public string EnumName { get; set; }
+
 	/// <summary>
 	/// Descriptions for the enum symbols, where the value MUST match the enum symbols in the main description
 	/// </summary>
 	public List<EnumDescription> ValuesDescriptions { get; set; } = new();
+
 	/// <inheritdoc />
 	public void Write(IOpenApiWriter writer, OpenApiSpecVersion specVersion)
 	{

src/Microsoft.OpenApi.OData.Reader/OpenApiExtensions/OpenApiEnumValuesDescriptionExtension.cs

@@ -12,7 +12,7 @@ namespace Microsoft.OpenApi.OData.OpenApiExtensions.Tests;
 
 public class OpenApiEnumValuesDescriptionExtensionTexts
 {
-	[Fact]
+    [Fact]
     public void ExtensionNameMatchesExpected()
     {
         // Arrange
@@ -26,7 +26,7 @@ public void ExtensionNameMatchesExpected()
         Assert.Equal(expectedName, name);
     }
 
-	[Fact]
+    [Fact]
     public void WritesNothingWhenNoValues()
     {
         // Arrange
@@ -40,23 +40,23 @@ public void WritesNothingWhenNoValues()
 
         // Assert
         Assert.Null(extension.EnumName);
-		Assert.Empty(extension.ValuesDescriptions);
+        Assert.Empty(extension.ValuesDescriptions);
         Assert.Empty(result);
     }
-	[Fact]
-	public void WritesEnumDescription()
-	{
-		// Arrange
+    [Fact]
+    public void WritesEnumDescription()
+    {
+        // Arrange
         OpenApiEnumValuesDescriptionExtension extension = new();
-		extension.EnumName = "TestEnum";
-		extension.ValuesDescriptions = new()
-		{
-			new() {
-				Description = "TestDescription",
-				Value = "TestValue",
-				Name = "TestName"
-			}
-		};
+        extension.EnumName = "TestEnum";
+        extension.ValuesDescriptions = new()
+        {
+            new() {
+                Description = "TestDescription",
+                Value = "TestValue",
+                Name = "TestName"
+            }
+        };
         using TextWriter sWriter = new StringWriter();
         OpenApiJsonWriter writer = new(sWriter);
 
@@ -65,11 +65,11 @@ public void WritesEnumDescription()
         string result = sWriter.ToString();
 
         // Assert
-		Assert.Contains("values", result);
-		Assert.Contains("modelAsString\": false", result);
-		Assert.Contains("name\": \"TestEnum", result);
-		Assert.Contains("description\": \"TestDescription", result);
-		Assert.Contains("value\": \"TestValue", result);
-		Assert.Contains("name\": \"TestName", result);
-	}
+        Assert.Contains("values", result);
+        Assert.Contains("modelAsString\": false", result);
+        Assert.Contains("name\": \"TestEnum", result);
+        Assert.Contains("description\": \"TestDescription", result);
+        Assert.Contains("value\": \"TestValue", result);
+        Assert.Contains("name\": \"TestName", result);
+    }
 }