Address review comments

Author: millicentachieng

src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiInfoGenerator.cs

@@ -103,15 +103,15 @@ private static Dictionary<string, IOpenApiExtension> GetExtensions(this ODataCon
         {
             Debug.Assert(context != null);
 
-            if (context.Settings.ShowAssemblyInfo)
+            if (context.Settings.IncludeAssemblyInfo)
             {
                 return new Dictionary<string, IOpenApiExtension>()
                 {
                     {
-                        "x-generatedBy",
+                        "x-ms-generated-by",
                         new OpenApiObject
                         {
-                            { "toolName", new OpenApiString("OpenAPI.NET.CSDL") },
+                            { "toolName", new OpenApiString("Microsoft.OpenApi.OData") },
                             { "toolVersion", new OpenApiString(Assembly.GetExecutingAssembly().GetName().Version.ToString()) }
                         }
                     }

src/Microsoft.OpenApi.OData.Reader/Microsoft.OpenAPI.OData.Reader.csproj

@@ -15,7 +15,7 @@
     <TargetFrameworks>netstandard2.0</TargetFrameworks>
     <PackageId>Microsoft.OpenApi.OData</PackageId>
     <SignAssembly>true</SignAssembly>
-    <Version>1.2.0-preview2</Version>
+    <Version>1.2.0-preview3</Version>
     <Description>This package contains the codes you need to convert OData CSDL to Open API Document of Model.</Description>
     <Copyright>© Microsoft Corporation. All rights reserved.</Copyright>
     <PackageTags>Microsoft OpenApi OData EDM</PackageTags>

src/Microsoft.OpenApi.OData.Reader/OpenApiConvertSettings.cs

@@ -279,7 +279,7 @@ public string PathPrefix
         /// Gets/Sets a value indicating whether to show the version of the assembly used for generating 
         /// Open API document
         /// </summary>
-        public bool ShowAssemblyInfo { get; set; } = true;
+        public bool IncludeAssemblyInfo { get; set; } = true;
 
         /// <summary>
         /// Get/Sets a dictionary containing a mapping of HTTP methods to custom link relation types 
@@ -341,7 +341,7 @@ internal OpenApiConvertSettings Clone()
                 AppendBoundOperationsOnDerivedTypeCastSegments = this.AppendBoundOperationsOnDerivedTypeCastSegments,
                 UseSuccessStatusCodeRange = this.UseSuccessStatusCodeRange,
                 EnableCount = this.EnableCount,
-                ShowAssemblyInfo = this.ShowAssemblyInfo,
+                IncludeAssemblyInfo = this.IncludeAssemblyInfo,
                 RefBaseCollectionPaginationCountResponse = this.RefBaseCollectionPaginationCountResponse
             };
 

src/Microsoft.OpenApi.OData.Reader/PublicAPI.Unshipped.txt

@@ -15,12 +15,12 @@ Microsoft.OpenApi.OData.OpenApiConvertSettings.ExpandDerivedTypesNavigationPrope
 Microsoft.OpenApi.OData.OpenApiConvertSettings.ExpandDerivedTypesNavigationProperties.set -> void
 Microsoft.OpenApi.OData.OpenApiConvertSettings.CustomXMLAttributesMapping.get -> System.Collections.Generic.Dictionary<string, string>
 Microsoft.OpenApi.OData.OpenApiConvertSettings.CustomXMLAttributesMapping.set -> void
+Microsoft.OpenApi.OData.OpenApiConvertSettings.IncludeAssemblyInfo.get -> bool
+Microsoft.OpenApi.OData.OpenApiConvertSettings.IncludeAssemblyInfo.set -> void
 Microsoft.OpenApi.OData.OpenApiConvertSettings.RefBaseCollectionPaginationCountResponse.get -> bool
 Microsoft.OpenApi.OData.OpenApiConvertSettings.RefBaseCollectionPaginationCountResponse.set -> void
 Microsoft.OpenApi.OData.OpenApiConvertSettings.RequireRestrictionAnnotationsToGenerateComplexPropertyPaths.get -> bool
 Microsoft.OpenApi.OData.OpenApiConvertSettings.RequireRestrictionAnnotationsToGenerateComplexPropertyPaths.set -> void
-Microsoft.OpenApi.OData.OpenApiConvertSettings.ShowAssemblyInfo.get -> bool
-Microsoft.OpenApi.OData.OpenApiConvertSettings.ShowAssemblyInfo.set -> void
 Microsoft.OpenApi.OData.OpenApiConvertSettings.ShowExternalDocs.get -> bool
 Microsoft.OpenApi.OData.OpenApiConvertSettings.ShowExternalDocs.set -> void
 Microsoft.OpenApi.OData.OpenApiConvertSettings.UseSuccessStatusCodeRange.get -> bool

test/Microsoft.OpenAPI.OData.Reader.Tests/EdmModelOpenApiExtensionsTest.cs

@@ -40,7 +40,7 @@ public void EmptyEdmModelToOpenApiJsonWorks(OpenApiSpecVersion specVersion)
             IEdmModel model = EdmModelHelper.EmptyModel;
             var openApiConvertSettings = new OpenApiConvertSettings();
             openApiConvertSettings.OpenApiSpecVersion = specVersion;
-            openApiConvertSettings.ShowAssemblyInfo = false;
+            openApiConvertSettings.IncludeAssemblyInfo = false;
 
             // Act
             string json = WriteEdmModelAsOpenApi(model, OpenApiFormat.Json, openApiConvertSettings);
@@ -66,7 +66,7 @@ public void EmptyEdmModelToOpenApiYamlWorks(OpenApiSpecVersion specVersion)
             IEdmModel model = EdmModelHelper.EmptyModel;
             var openApiConvertSettings = new OpenApiConvertSettings();
             openApiConvertSettings.OpenApiSpecVersion = specVersion; 
-            openApiConvertSettings.ShowAssemblyInfo = false;
+            openApiConvertSettings.IncludeAssemblyInfo = false;
 
             // Act
             string yaml = WriteEdmModelAsOpenApi(model, OpenApiFormat.Yaml, openApiConvertSettings);
@@ -94,7 +94,7 @@ public void BasicEdmModelToOpenApiJsonWorks(OpenApiSpecVersion specVersion)
             {
                 OpenApiSpecVersion = specVersion,
                 ShowSchemaExamples = true, // test for schema examples
-                ShowAssemblyInfo = false
+                IncludeAssemblyInfo = false
             };
 
             // Act
@@ -123,7 +123,7 @@ public void BasicEdmModelToOpenApiYamlWorks(OpenApiSpecVersion specVersion)
             {
                 OpenApiSpecVersion = specVersion,
                 ShowSchemaExamples = true,
-                ShowAssemblyInfo = false
+                IncludeAssemblyInfo = false
             };
 
             // Act
@@ -153,7 +153,7 @@ public void MultipleSchemasEdmModelToOpenApiJsonWorks(OpenApiSpecVersion specVer
                 OpenApiSpecVersion = specVersion,
                 ShowLinks = true, // test Links
                 ShowSchemaExamples = true,
-                ShowAssemblyInfo = false
+                IncludeAssemblyInfo = false
             };
 
             // Act
@@ -183,7 +183,7 @@ public void MultipleSchemasEdmModelToOpenApiYamlWorks(OpenApiSpecVersion specVer
                 OpenApiSpecVersion = specVersion,
                 ShowLinks = true, // test Links
                 ShowSchemaExamples = true,
-                ShowAssemblyInfo = false
+                IncludeAssemblyInfo = false
             };
 
             // Act
@@ -218,7 +218,7 @@ public void TripServiceMetadataToOpenApiJsonWorks(OpenApiSpecVersion specVersion
                 AddSingleQuotesForStringParameters = true,
                 AddEnumDescriptionExtension = true,
                 AppendBoundOperationsOnDerivedTypeCastSegments = true,
-                ShowAssemblyInfo = false
+                IncludeAssemblyInfo = false
             };
             // Act
             string json = WriteEdmModelAsOpenApi(model, OpenApiFormat.Json, settings);
@@ -253,7 +253,7 @@ public void TripServiceMetadataToOpenApiYamlWorks(OpenApiSpecVersion specVersion
                 AddSingleQuotesForStringParameters = true,
                 AddEnumDescriptionExtension = true,
                 AppendBoundOperationsOnDerivedTypeCastSegments = true,
-                ShowAssemblyInfo = false
+                IncludeAssemblyInfo = false
             };
 
             // Act