[Fix] Updates operationIds of navigation property paths with OData type cast segments (#443)

* Account for OData type cast segments present in NavigationProperty path kind

* Update integration tests

* Retrieve type cast segments if it appears before any navigation property

* Update release notes

* Update src/Microsoft.OpenApi.OData.Reader/Common/EdmModelHelper.cs

---------

Co-authored-by: Vincent Biret <[email protected]>

Author: irvinesunday

src/Microsoft.OpenApi.OData.Reader/Common/EdmModelHelper.cs

@@ -161,19 +161,25 @@ internal static IList<string> RetrieveNavigationPropertyPathsOperationIdSegments
                 navigationSource.Name
             };
 
-            IEnumerable<ODataNavigationPropertySegment> navPropSegments = path.Segments.Skip(1).OfType<ODataNavigationPropertySegment>();
-            Utils.CheckArgumentNull(navPropSegments, nameof(navPropSegments));
+            // For navigation property paths with odata type cast segments
+            // the OData type cast segments identifiers will be used in the operation id
+            IEnumerable<ODataSegment> segments = path.Segments.Skip(1).Where(static s => s is ODataNavigationPropertySegment || s is ODataTypeCastSegment);
+            Utils.CheckArgumentNull(segments, nameof(segments));
 
-            foreach (var segment in navPropSegments)
+            string previousTypeCastSegmentId = null;
+            foreach (var segment in segments)
             {
-                if (segment == navPropSegments.Last())
+                if (segment is ODataNavigationPropertySegment navPropSegment)
                 {
-                    items.Add(segment.NavigationProperty.Name);
-                    break;
+                    items.Add(navPropSegment.NavigationProperty.Name);
                 }
-                else
+                else if (segment is ODataTypeCastSegment typeCastSegment && path.Kind == ODataPathKind.NavigationProperty)
                 {
-                    items.Add(segment.NavigationProperty.Name);
+                    // Only the last OData type cast segment identifier is added to the operation id
+                    items.Remove(previousTypeCastSegmentId);
+                    IEdmSchemaElement schemaElement = typeCastSegment.StructuredType as IEdmSchemaElement;
+                    previousTypeCastSegmentId = "As" + Utils.UpperFirstChar(schemaElement.Name);
+                    items.Add(previousTypeCastSegmentId);
                 }
             }
 

src/Microsoft.OpenApi.OData.Reader/Microsoft.OpenAPI.OData.Reader.csproj

@@ -15,7 +15,7 @@
     <TargetFrameworks>netstandard2.0</TargetFrameworks>
     <PackageId>Microsoft.OpenApi.OData</PackageId>
     <SignAssembly>true</SignAssembly>
-    <Version>1.5.0-preview7</Version>
+    <Version>1.5.0-preview8</Version>
     <Description>This package contains the codes you need to convert OData CSDL to Open API Document of Model.</Description>
     <Copyright>© Microsoft Corporation. All rights reserved.</Copyright>
     <PackageTags>Microsoft OpenApi OData EDM</PackageTags>
@@ -28,6 +28,7 @@
 - Use containment together with RequiresExplicitBinding annotation to check whether to append bound operations to navigation properties #430
 - Adds schema to content types of stream properties that have a collection of acceptable media types #435
 - Retrieves complex properties of derived types #437
+- Updates operationIds of navigation property paths with OData type cast segments #442
     </PackageReleaseNotes>
     <AssemblyName>Microsoft.OpenApi.OData.Reader</AssemblyName>
     <AssemblyOriginatorKeyFile>..\..\tool\Microsoft.OpenApi.OData.snk</AssemblyOriginatorKeyFile>