Code cleanup and format.

Author: python3kgae

lib/DXIL/DxilShaderFlags.cpp

@@ -573,7 +573,7 @@ ShaderFlags ShaderFlags::CollectShaderFlags(const Function *F,
         if (!OP::IsDxilOpFunc(CI->getCalledFunction()))
           continue;
         DXIL::OpCode dxilOp = hlsl::OP::getOpCode(CI);
-        if (dxilOp >= DXIL::OpCode::NumOpCodes)
+        if (dxilOp == DXIL::OpCode::NumOpCodes)
           continue;
         if (hlsl::OP::IsDxilOpWave(dxilOp))
           hasWaveOps = true;

lib/HLSL/DxilValidation.cpp

@@ -3239,15 +3239,14 @@ static void ValidateFunctionBody(Function *F, ValidationContext &ValCtx) {
           }
 
           unsigned opcode = OpcodeConst->getLimitedValue();
-          DXIL::OpCode dxilOpcode = (DXIL::OpCode)opcode;
-
-          if (dxilOpcode >= DXIL::OpCode::NumOpCodes) {
+          if (opcode >= static_cast<unsigned>(DXIL::OpCode::NumOpCodes)) {
             ValCtx.EmitInstrFormatError(
                 &I, ValidationRule::InstrIllegalDXILOpCode,
                 {std::to_string((unsigned)DXIL::OpCode::NumOpCodes),
                  std::to_string(opcode)});
             continue;
           }
+          DXIL::OpCode dxilOpcode = (DXIL::OpCode)opcode;
 
           bool IllegalOpFunc = true;
           for (auto &it : hlslOP->GetOpFuncList(dxilOpcode)) {

utils/hct/hctdb_instrhelp.py

@@ -722,7 +722,12 @@ def print_opfunc_oload_type(self):
             for opcode in opcodes:
                 line = line + "case OpCode::{name}".format(name=opcode + ":\n")
 
-            line = line + "  if (FT->getNumParams() <= " + str(index) + ") return nullptr;\n"
+            line = (
+                line
+                + "  if (FT->getNumParams() <= "
+                + str(index)
+                + ") return nullptr;\n"
+            )
             line = line + "  return FT->getParamType(" + str(index) + ");"
             print(line)
 
@@ -732,7 +737,12 @@ def print_opfunc_oload_type(self):
             for opcode in opcodes:
                 line = line + "case OpCode::{name}".format(name=opcode + ":\n")
 
-            line = line + "  if (FT->getNumParams() <= " + str(index) + ") return nullptr;\n"
+            line = (
+                line
+                + "  if (FT->getNumParams() <= "
+                + str(index)
+                + ") return nullptr;\n"
+            )
             line = (
                 line
                 + "  return FT->getParamType("