Skip to content

Commit b1f2290

Browse files
Update to v0.11.1
See release notes
1 parent 7c25c68 commit b1f2290

File tree

5 files changed

+18
-8
lines changed

5 files changed

+18
-8
lines changed

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,11 @@ dependency management via Bower, npm and other package managers.
88

99
All documentation is also located in the [angularUtils project](https://github.com/michaelbromley/angularUtils/tree/master/src/directives/pagination).
1010

11+
## Changelog
12+
13+
Please see the [releases page](https://github.com/michaelbromley/angularUtils-pagination/releases) for details
14+
of each released version.
15+
1116
## Issues
1217

1318
Please submit any issues to the [angularUtils issue tracker](https://github.com/michaelbromley/angularUtils/issues), not this one.

bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "angularUtils-pagination",
3-
"version": "0.11.0",
3+
"version": "0.11.1",
44
"homepage": "https://github.com/michaelbromley/angularUtils/tree/master/src/directives/pagination",
55
"authors": [
66
"Michael Bromley <[email protected]>"

dirPagination.js

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,12 @@
6868
// Now that we have access to the `scope` we can interpolate any expression given in the paginationId attribute and
6969
// potentially register a new ID if it evaluates to a different value than the rawId.
7070
var paginationId = $parse(attrs.paginationId)(scope) || attrs.paginationId || DEFAULT_ID;
71+
72+
// (TODO: this seems sound, but I'm reverting as many bug reports followed it's introduction in 0.11.0.
73+
// Needs more investigation.)
7174
// In case rawId != paginationId we deregister using rawId for the sake of general cleanliness
7275
// before registering using paginationId
73-
paginationService.deregisterInstance(rawId);
76+
// paginationService.deregisterInstance(rawId);
7477
paginationService.registerInstance(paginationId);
7578

7679
var repeatExpression = getRepeatExpression(expression, paginationId);
@@ -105,12 +108,14 @@
105108

106109
// Delegate to the link function returned by the new compilation of the ng-repeat
107110
compiled(scope);
108-
111+
112+
// (TODO: Reverting this due to many bug reports in v 0.11.0. Needs investigation as the
113+
// principle is sound)
109114
// When the scope is destroyed, we make sure to remove the reference to it in paginationService
110115
// so that it can be properly garbage collected
111-
scope.$on('$destroy', function destroyDirPagination() {
112-
paginationService.deregisterInstance(paginationId);
113-
});
116+
// scope.$on('$destroy', function destroyDirPagination() {
117+
// paginationService.deregisterInstance(paginationId);
118+
// });
114119
};
115120
}
116121

package.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Package.describe({
22
name: 'angularutils:pagination',
33
summary: 'Magical automatic pagination for anything in AngularJS',
4-
version: '0.11.0',
4+
version: '0.11.1',
55
git: 'https://github.com/michaelbromley/angularUtils-pagination'
66
});
77

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "angular-utils-pagination",
3-
"version": "0.11.0",
3+
"version": "0.11.1",
44
"description": "Magical automatic pagination for anything in AngularJS",
55
"main": "index.js",
66
"scripts": {

0 commit comments

Comments
 (0)