Skip to content

Commit c4d3521

Browse files
kiukchungfacebook-github-bot
authored andcommitted
(torchx/runner) properly log appdef properties in dryrun (#1159)
Summary: We were not logging all the information about the appdef in the dryrun API. Differential Revision: D86014124
1 parent 1e0492c commit c4d3521

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

torchx/runner/api.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -420,7 +420,7 @@ def dryrun(
420420
scheduler,
421421
runcfg=json.dumps(cfg) if cfg else None,
422422
workspace=str(workspace),
423-
):
423+
) as ctx:
424424
sched = self._scheduler(scheduler)
425425
resolved_cfg = sched.run_opts().resolve(cfg)
426426

@@ -450,6 +450,14 @@ def dryrun(
450450
sched._validate(app, scheduler, resolved_cfg)
451451
dryrun_info = sched.submit_dryrun(app, resolved_cfg)
452452
dryrun_info._scheduler = scheduler
453+
454+
event = ctx._torchx_event
455+
event.scheduler = scheduler
456+
event.runcfg = json.dumps(cfg) if cfg else None
457+
event.app_id = app.name
458+
event.app_image = none_throws(dryrun_info._app).roles[0].image
459+
event.app_metadata = app.metadata
460+
453461
return dryrun_info
454462

455463
def scheduler_run_opts(self, scheduler: str) -> runopts:

0 commit comments

Comments
 (0)