Skip to content

Conversation

@FelonEkonom
Copy link
Member

No description provided.

@FelonEkonom FelonEkonom requested a review from mat-hek as a code owner March 19, 2024 16:41
@FelonEkonom FelonEkonom self-assigned this Mar 19, 2024
mix.exs Outdated
{:telemetry, "~> 1.0"},
{:bunch, "~> 1.6"},
{:ratio, "~> 3.0"},
{:ratio, ">= 4.0.1 and < 5.0.0"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an equivalent of "~>> 4.0.1". However, I think it should be

Suggested change
{:ratio, ">= 4.0.1 and < 5.0.0"},
{:ratio, "~> 3.0 or ~>> 4.0.1"},

so it doesn't block updating plugins that depend on ratio

@FelonEkonom FelonEkonom requested a review from mat-hek March 26, 2024 10:34
@FelonEkonom FelonEkonom merged commit ef91c4d into master Mar 26, 2024
@FelonEkonom FelonEkonom deleted the ratio-4.0.1 branch March 26, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants