This CL makes two changes:

1. Adds a new delegate method `chipFieldShouldEndEditing` to match `chipFieldShouldBeginEditing`
2. Moved the call to the chip field delegate for `chipFieldDidBeginEditing` and `chipFieldDidEndEditing` so they are fired at the correct time.

I noticed that the UITextFieldDelegate method `textFieldShouldBeginEditing` can be called without actually becoming the first responder if the previous first responder doesn't resign it. That meant that the chip field would still claim to have begun editing even if it hadn't.

PiperOrigin-RevId: 367240207

Author: Nobody

components/Chips/src/MDCChipField.m

@@ -557,18 +557,27 @@ - (BOOL)textFieldShouldBeginEditing:(UITextField *)textField {
   if ([self.delegate respondsToSelector:@selector(chipFieldShouldBeginEditing:)]) {
     shouldBeginEditing = [self.delegate chipFieldShouldBeginEditing:self];
   }
-  if (shouldBeginEditing) {
-    if (textField == self.textField) {
-      [self deselectAllChips];
-    }
-    if ([self.delegate respondsToSelector:@selector(chipFieldDidBeginEditing:)]) {
-      [self.delegate chipFieldDidBeginEditing:self];
-    }
-  }
   return shouldBeginEditing;
 }
 
 - (BOOL)textFieldShouldEndEditing:(UITextField *)textField {
+  BOOL shouldEndEditing = YES;
+  if ([self.delegate respondsToSelector:@selector(chipFieldShouldEndEditing:)]) {
+    shouldEndEditing = [self.delegate chipFieldShouldEndEditing:self];
+  }
+  return shouldEndEditing;
+}
+
+- (void)textFieldDidBeginEditing:(UITextField *)textField {
+  if (textField == self.textField) {
+    [self deselectAllChips];
+  }
+  if ([self.delegate respondsToSelector:@selector(chipFieldDidBeginEditing:)]) {
+    [self.delegate chipFieldDidBeginEditing:self];
+  }
+}
+
+- (void)textFieldDidEndEditing:(UITextField *)textField {
   if ((self.delimiter & MDCChipFieldDelimiterDidEndEditing) == MDCChipFieldDelimiterDidEndEditing) {
     if (textField == self.textField) {
       [self commitInput];
@@ -577,7 +586,6 @@ - (BOOL)textFieldShouldEndEditing:(UITextField *)textField {
   if ([self.delegate respondsToSelector:@selector(chipFieldDidEndEditing:)]) {
     [self.delegate chipFieldDidEndEditing:self];
   }
-  return YES;
 }
 
 - (BOOL)textFieldShouldReturn:(UITextField *)textField {

components/Chips/src/MDCChipFieldDelegate.h

@@ -23,6 +23,13 @@
  */
 - (BOOL)chipFieldShouldBeginEditing:(nonnull MDCChipField *)chipField;
 
+/**
+ Asks the delegate if editing should end in the specified chip field.
+
+ @param chipField The @c MDCChipField where is about to end.
+ */
+- (BOOL)chipFieldShouldEndEditing:(nonnull MDCChipField *)chipField;
+
 /**
  Tells the delegate that editing began in the specified chip field.
 

components/Chips/tests/unit/ChipsDelegateTests.m

@@ -24,7 +24,9 @@ @interface ChipsDelegateTests : XCTestCase <MDCChipFieldDelegate>
 @property(nonatomic, nullable) MDCChipField *chip;
 @property(nonatomic, copy, nullable) NSString *delegateTextInput;
 @property(nonatomic) BOOL delegateShouldBeginEditing;
+@property(nonatomic) BOOL delegateShouldEndEditing;
 @property(nonatomic) BOOL delegateDidBeginEditingCalled;
+@property(nonatomic) BOOL delegateDidEndEditingCalled;
 
 @end
 
@@ -36,14 +38,17 @@ - (void)setUp {
   self.chip = [[MDCChipField alloc] init];
   self.chip.delegate = self;
   self.delegateShouldBeginEditing = YES;
+  self.delegateShouldEndEditing = YES;
 }
 
 - (void)tearDown {
   self.delegateTextInput = nil;
   self.chip.delegate = nil;
   self.chip = nil;
   self.delegateShouldBeginEditing = YES;
+  self.delegateShouldEndEditing = YES;
   self.delegateDidBeginEditingCalled = NO;
+  self.delegateDidEndEditingCalled = NO;
   [super tearDown];
 }
 
@@ -68,7 +73,7 @@ - (void)testTouchUpOnClearButtonInvokesDidChangeInputOnDelegate {
   XCTAssertEqual((unsigned long)self.delegateTextInput.length, 0UL);
 }
 
-- (void)testDelegateShouldNotBeginEditingDoesNotTriggerDidBeginEditing {
+- (void)testDelegateShouldNotBeginEditing {
   // Given
   self.delegateShouldBeginEditing = NO;
 
@@ -78,10 +83,9 @@ - (void)testDelegateShouldNotBeginEditingDoesNotTriggerDidBeginEditing {
 
   // Then
   XCTAssertFalse(shouldBeginEditing);
-  XCTAssertFalse(self.delegateDidBeginEditingCalled);
 }
 
-- (void)testShouldBeginEditingTriggersDidBeginEditing {
+- (void)testShouldBeginEditing {
   // Given
   self.delegateShouldBeginEditing = YES;
 
@@ -91,9 +95,48 @@ - (void)testShouldBeginEditingTriggersDidBeginEditing {
 
   // Then
   XCTAssertTrue(shouldBeginEditing);
+}
+
+- (void)testTextFieldDidBeginEditingTriggersDidBeginEditing {
+  // When
+  [self.chip.textField.delegate textFieldDidBeginEditing:self.chip.textField];
+
+  // Then
   XCTAssertTrue(self.delegateDidBeginEditingCalled);
 }
 
+- (void)testDelegateShouldNotEndEditing {
+  // Given
+  self.delegateShouldEndEditing = NO;
+
+  // When
+  BOOL shouldEndEditing =
+      [self.chip.textField.delegate textFieldShouldEndEditing:self.chip.textField];
+
+  // Then
+  XCTAssertFalse(shouldEndEditing);
+}
+
+- (void)testDelegateShouldEndEditing {
+  // Given
+  self.delegateShouldEndEditing = YES;
+
+  // When
+  BOOL shouldEndEditing =
+      [self.chip.textField.delegate textFieldShouldEndEditing:self.chip.textField];
+
+  // Then
+  XCTAssertTrue(shouldEndEditing);
+}
+
+- (void)testTextFieldDidEndEditingTriggersDidEndEditing {
+  // When
+  [self.chip.textField.delegate textFieldDidEndEditing:self.chip.textField];
+
+  // Then
+  XCTAssertTrue(self.delegateDidEndEditingCalled);
+}
+
 #pragma mark - MDCChipFieldDelegate
 
 - (void)chipField:(nonnull MDCChipField *)chipField didChangeInput:(nullable NSString *)input {
@@ -108,4 +151,12 @@ - (void)chipFieldDidBeginEditing:(MDCChipField *)chipField {
   self.delegateDidBeginEditingCalled = YES;
 }
 
+- (BOOL)chipFieldShouldEndEditing:(MDCChipField *)chipField {
+  return self.delegateShouldEndEditing;
+}
+
+- (void)chipFieldDidEndEditing:(MDCChipField *)chipField {
+  self.delegateDidEndEditingCalled = YES;
+}
+
 @end