Skip to content

Conversation

civitaspo
Copy link
Owner

@civitaspo civitaspo commented Jan 21, 2020

This plugin uses the very old gradle, so I changed the version to the latest one. And I change the jruby-gradle dependency because jruby-gradle v0.1.5 already cannot release gems.

I will be making a lot of Pull Requests for the next release, so please don't release this change as a new version yet.

@civitaspo civitaspo changed the title Use latest gradle (v6.1) with jruby-gradle v1.5.0 [WIP] Use latest gradle (v6.1) with jruby-gradle v1.5.0 Jan 21, 2020
@civitaspo civitaspo changed the title [WIP] Use latest gradle (v6.1) with jruby-gradle v1.5.0 Use latest gradle (v6.1) with jruby-gradle v1.5.0 Jan 21, 2020
@civitaspo
Copy link
Owner Author

civitaspo commented Jan 21, 2020

The tests were broken before I made this change. I will fix it with another pull request later. (EDIT: I had the wrong way to run the test.)

@civitaspo
Copy link
Owner Author

@lulichn How can I run the tests? This seems to work when I set the environment variables appropriately, but I cannot know the variables... ref. https://circleci.com/gh/lulichn/embulk-input-dynamodb/49

@civitaspo
Copy link
Owner Author

@lulichn How can I run the tests? This seems to work when I set the environment variables appropriately, but I cannot know the variables... ref. https://circleci.com/gh/lulichn/embulk-input-dynamodb/49

I got it. These variables are generated in your AWS account, right? The tests are succeeded when I create IAM User which have the AmazonDynamoDBFullAccess policy and I generate credentials and test data.

So, this pull-request is ready to merge.

@civitaspo civitaspo requested a review from higarin January 22, 2020 00:28
@higarin higarin merged commit 7efea7d into civitaspo:master Jan 26, 2020
@civitaspo civitaspo mentioned this pull request Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants