Remove try catch block from buckslip test and test directly

Author: mananshah78424

__tests__/BuckslipsApi.spec.ts

@@ -1,18 +1,6 @@
-import {
-  CONFIG_FOR_INTEGRATION,
-  FILE_LOCATION,
-  FILE_LOCATION_4X6,
-  FILE_LOCATION_6X18,
-} from "./testFixtures";
+import { CONFIG_FOR_INTEGRATION, FILE_LOCATION } from "./testFixtures";
 import { BuckslipsApi } from "../api/buckslips-api";
-import {
-  Buckslip,
-  BuckslipEditable,
-  BuckslipEditableSizeEnum,
-} from "../models";
-import FormData from "form-data";
-import fs from "fs";
-import { create } from "domain";
+import { BuckslipEditable, BuckslipEditableSizeEnum } from "../models";
 
 describe("BuckSlipsApi", () => {
   it("Buckslips API can be instantiated", () => {
@@ -51,41 +39,29 @@ describe("BuckSlipsApi", () => {
     it("creates, updates, and gets a buckslip", async () => {
       const buckslipsApi = new BuckslipsApi(CONFIG_FOR_INTEGRATION);
 
-      try {
-        // Create buckslip with proper file references
-        const createdBe = await buckslipsApi.create(createBe);
-        expect(createdBe.id).toBeDefined();
-        expect(createdBe.description).toEqual(createBe.description);
+      // Create buckslip with proper file references
+      const createdBe = await buckslipsApi.create(createBe);
+      expect(createdBe.id).toBeDefined();
+      expect(createdBe.description).toEqual(createBe.description);
 
-        // Get
-        const retrievedBe = await buckslipsApi.get(createdBe.id as string);
-        expect(retrievedBe).toEqual(
-          expect.objectContaining({
-            id: createdBe.id,
-          })
-        );
+      // Get
+      const retrievedBe = await buckslipsApi.get(createdBe.id as string);
+      expect(retrievedBe).toEqual(
+        expect.objectContaining({
+          id: createdBe.id,
+        })
+      );
 
-        // Update
-        const updates = new BuckslipEditable({
-          description: "updated buckslip",
-        });
-        const updatedBe = await buckslipsApi.update(
-          retrievedBe.id as string,
-          updates
-        );
-        expect(updatedBe).toBeDefined();
-        expect(updatedBe.description).toEqual("updated buckslip");
-      } catch (error) {
-        // If creation fails due to API requirements, just test the API structure
-        expect(buckslipsApi).toEqual(
-          expect.objectContaining({
-            create: expect.any(Function),
-            get: expect.any(Function),
-            update: expect.any(Function),
-            delete: expect.any(Function),
-          })
-        );
-      }
+      // Update
+      const updates = new BuckslipEditable({
+        description: "updated buckslip",
+      });
+      const updatedBe = await buckslipsApi.update(
+        retrievedBe.id as string,
+        updates
+      );
+      expect(updatedBe).toBeDefined();
+      expect(updatedBe.description).toEqual("updated buckslip");
     });
   });
 
@@ -100,20 +76,10 @@ describe("BuckSlipsApi", () => {
     });
 
     it("lists buckslips", async () => {
-      try {
-        const response = await new BuckslipsApi(CONFIG_FOR_INTEGRATION).List();
-        expect(response.data).toBeDefined();
-        // Don't require data to exist, just verify the API works
-        expect(Array.isArray(response.data)).toBeTruthy();
-      } catch (error) {
-        // If listing fails due to API requirements in CI, just verify the API structure exists
-        const buckslipsApi = new BuckslipsApi(CONFIG_FOR_INTEGRATION);
-        expect(buckslipsApi).toEqual(
-          expect.objectContaining({
-            List: expect.any(Function),
-          })
-        );
-      }
+      const response = await new BuckslipsApi(CONFIG_FOR_INTEGRATION).List();
+      expect(response.data).toBeDefined();
+      // Don't require data to exist, just verify the API works
+      expect(Array.isArray(response.data)).toBeTruthy();
     });
   });
 });