Address Comments

Author: Mr-Anyone

clang/docs/ReleaseNotes.rst

@@ -253,8 +253,8 @@ Bug Fixes in This Version
 -------------------------
 - Fix a crash when marco name is empty in ``#pragma push_macro("")`` or
   ``#pragma pop_macro("")``. (#GH149762).
-- Fix a crash in variable length array (e.g. int a[*]) function parameter type 
-  being used in `_Countof` expression. (#GH152826)
+- Fix a crash in variable length array (e.g. ``int a[*]``) function parameter type 
+  being used in ``_Countof`` expression. (#GH152826)
 - `-Wunreachable-code`` now diagnoses tautological or contradictory
   comparisons such as ``x != 0 || x != 1.0`` and ``x == 0 && x == 1.0`` on
   targets that treat ``_Float16``/``__fp16`` as native scalar types. Previously

clang/lib/AST/ExprConstant.cpp

@@ -15354,7 +15354,7 @@ bool IntExprEvaluator::VisitUnaryExprOrTypeTraitExpr(
     assert(VAT);
     if (VAT->getElementType()->isArrayType()) {
       // Variable array size expression could be missing (e.g. int a[*][10]) In
-      // that case, it can't be a constant expression
+      // that case, it can't be a constant expression.
       if (!VAT->getSizeExpr()) {
         Info.FFDiag(E->getBeginLoc());
         return false;
@@ -17898,7 +17898,7 @@ static ICEDiag CheckICE(const Expr* E, const ASTContext &Ctx) {
         const auto *VAT = Ctx.getAsVariableArrayType(ArgTy);
         if (VAT->getElementType()->isArrayType())
           // Variable array size expression could be missing (e.g. int a[*][10])
-          // In that case, it can't be a constant expression
+          // In that case, it can't be a constant expression.
           return VAT->getSizeExpr() ? CheckICE(VAT->getSizeExpr(), Ctx)
                                     : ICEDiag(IK_NotICE, E->getBeginLoc());
 

clang/test/Sema/gh152826.c

@@ -4,3 +4,4 @@
 
 void gh152826(char (*a)[*][5], int (*x)[_Countof (*a)]);
 void more_likely_in_practice(unsigned long size_one, int (*a)[*][5], int b[_Countof(*a)]);
+void f(int (*x)[*][1][*][2][*][*][3][*], int q[_Countof(*x)]);