Fix thread handle leak on Windows

lmielick · lmielick · commit c2a0023aef40 · 2025-09-08T11:21:55.000Z
diff --git a/llvm/lib/Support/Windows/Threading.inc b/llvm/lib/Support/Windows/Threading.inc
@@ -40,6 +40,8 @@ llvm_execute_on_thread_impl(unsigned(__stdcall *ThreadFunc)(void *), void *Arg,
 void llvm_thread_join_impl(HANDLE hThread) {
   if (::WaitForSingleObject(hThread, INFINITE) == WAIT_FAILED)
     ReportLastErrorFatal("WaitForSingleObject failed");
+  if (::CloseHandle(hThread) == FALSE)
+    ReportLastErrorFatal("CloseHandle failed");
 }
 
 void llvm_thread_detach_impl(HANDLE hThread) {

Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,8 @@ llvm_execute_on_thread_impl(unsigned(__stdcall ThreadFunc)(void ), void *Arg,`
`40`	`40`	`void llvm_thread_join_impl(HANDLE hThread) {`
`41`	`41`	`if (::WaitForSingleObject(hThread, INFINITE) == WAIT_FAILED)`
`42`	`42`	`ReportLastErrorFatal("WaitForSingleObject failed");`
	`43`	`+ if (::CloseHandle(hThread) == FALSE)`
	`44`	`+ ReportLastErrorFatal("CloseHandle failed");`
`43`	`45`	`}`
`44`	`46`
`45`	`47`	`void llvm_thread_detach_impl(HANDLE hThread) {`