Skip to content

Commit 6629bb1

Browse files
rafapraxbrianchandotcom
authored andcommitted
LPD-43475 DRY, extract default implementation to interface
1 parent 7118e95 commit 6629bb1

File tree

6 files changed

+7
-44
lines changed

6 files changed

+7
-44
lines changed

modules/apps/portal-security/portal-security-password-encryptor-impl/src/main/java/com/liferay/portal/security/password/encryptor/internal/CryptPasswordEncryptor.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
package com.liferay.portal.security.password.encryptor.internal;
77

8-
import com.liferay.petra.string.CharPool;
98
import com.liferay.portal.kernel.exception.PwdEncryptorException;
109
import com.liferay.portal.kernel.security.SecureRandom;
1110
import com.liferay.portal.kernel.security.pwd.PasswordEncryptor;
@@ -54,14 +53,6 @@ public String encrypt(
5453
}
5554
}
5655

57-
@Override
58-
public String getEncryptionAlgorithmConfiguration(
59-
String encryptedPassword) {
60-
61-
return encryptedPassword.substring(
62-
1, encryptedPassword.indexOf(CharPool.CLOSE_CURLY_BRACE));
63-
}
64-
6556
protected byte[] getSalt(String encryptedPassword)
6657
throws PwdEncryptorException {
6758

modules/apps/portal-security/portal-security-password-encryptor-impl/src/main/java/com/liferay/portal/security/password/encryptor/internal/DefaultPasswordEncryptor.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
package com.liferay.portal.security.password.encryptor.internal;
77

8-
import com.liferay.petra.string.CharPool;
98
import com.liferay.portal.kernel.security.pwd.PasswordEncryptor;
109
import com.liferay.portal.kernel.util.DigesterUtil;
1110

@@ -29,12 +28,4 @@ public String encrypt(
2928
return DigesterUtil.digest(algorithm, plainTextPassword);
3029
}
3130

32-
@Override
33-
public String getEncryptionAlgorithmConfiguration(
34-
String encryptedPassword) {
35-
36-
return encryptedPassword.substring(
37-
1, encryptedPassword.indexOf(CharPool.CLOSE_CURLY_BRACE));
38-
}
39-
4031
}

modules/apps/portal-security/portal-security-password-encryptor-impl/src/main/java/com/liferay/portal/security/password/encryptor/internal/NullPasswordEncryptor.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
package com.liferay.portal.security.password.encryptor.internal;
77

8-
import com.liferay.petra.string.CharPool;
98
import com.liferay.portal.kernel.security.pwd.PasswordEncryptor;
109

1110
import org.osgi.service.component.annotations.Component;
@@ -28,12 +27,4 @@ public String encrypt(
2827
return plainTextPassword;
2928
}
3029

31-
@Override
32-
public String getEncryptionAlgorithmConfiguration(
33-
String encryptedPassword) {
34-
35-
return encryptedPassword.substring(
36-
1, encryptedPassword.indexOf(CharPool.CLOSE_CURLY_BRACE));
37-
}
38-
3930
}

modules/apps/portal-security/portal-security-password-encryptor-impl/src/main/java/com/liferay/portal/security/password/encryptor/internal/SSHAPasswordEncryptor.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
package com.liferay.portal.security.password.encryptor.internal;
77

8-
import com.liferay.petra.string.CharPool;
98
import com.liferay.portal.kernel.exception.PwdEncryptorException;
109
import com.liferay.portal.kernel.io.BigEndianCodec;
1110
import com.liferay.portal.kernel.security.SecureRandomUtil;
@@ -68,14 +67,6 @@ public String encrypt(
6867
}
6968
}
7069

71-
@Override
72-
public String getEncryptionAlgorithmConfiguration(
73-
String encryptedPassword) {
74-
75-
return encryptedPassword.substring(
76-
1, encryptedPassword.indexOf(CharPool.CLOSE_CURLY_BRACE));
77-
}
78-
7970
protected byte[] getSaltBytes(String encryptedPassword)
8071
throws PwdEncryptorException {
8172

modules/apps/portal-security/portal-security-password-encryptor-impl/src/test/java/com/liferay/portal/security/password/encryptor/internal/PasswordEncryptorUtilTest.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -344,13 +344,6 @@ public String encrypt(
344344
algorithm.substring(algorithm.indexOf('/') + 1);
345345
}
346346

347-
@Override
348-
public String getEncryptionAlgorithmConfiguration(
349-
String encryptedPassword) {
350-
351-
return null;
352-
}
353-
354347
}
355348

356349
}

portal-kernel/src/com/liferay/portal/kernel/security/pwd/PasswordEncryptor.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
package com.liferay.portal.kernel.security.pwd;
77

8+
import com.liferay.petra.string.CharPool;
89
import com.liferay.portal.kernel.exception.PwdEncryptorException;
910

1011
import org.osgi.annotation.versioning.ProviderType;
@@ -50,6 +51,11 @@ public String encrypt(
5051
String encryptedPassword, boolean upgradeHashSecurity)
5152
throws PwdEncryptorException;
5253

53-
public String getEncryptionAlgorithmConfiguration(String encryptedPassword);
54+
public default String getEncryptionAlgorithmConfiguration(
55+
String encryptedPassword) {
56+
57+
return encryptedPassword.substring(
58+
1, encryptedPassword.indexOf(CharPool.CLOSE_CURLY_BRACE));
59+
}
5460

5561
}

0 commit comments

Comments
 (0)