fix(BatchPublishing): Make topic.AddToBatch threadsafe #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
approved these changes
Jun 25, 2025
messagebatch.go
Outdated
Comment on lines
18
to
30
| func (mb *MessageBatch) addMessage(msg *Message) { | ||
| mb.mu.Lock() | ||
| defer mb.mu.Unlock() | ||
| mb.messages = append(mb.messages, msg) | ||
| } | ||
|
|
||
| func (mb *MessageBatch) takeMessages() []*Message { | ||
| mb.mu.Lock() | ||
| defer mb.mu.Unlock() | ||
| messages := mb.messages | ||
| mb.messages = nil | ||
| return messages | ||
| } |
There was a problem hiding this comment.
NIT: I prefer just add and take
MarcoPolo
force-pushed
the
marco/batch-publish-thread-safe
branch
from
24139da to
bf93aab
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
topic.Publish is already thread safe. topic.AddToBatch should strive to follow similar semantics.
Looking at how this would integrate with Prysm, they use separate goroutines per message they'd like to batch.