Skip to content

Commit 30e4f38

Browse files
nswonqmonnet
authored andcommitted
bpf: bpftool: Setting error code in do_loader()
We are missing setting error code in do_loader() when bpf_object__open_file() fails. This means the command's exit status code will be successful, even though the operation failed. So make sure to return the correct error code. To maintain consistency with other locations where bpf_object__open_file() is called, return -1. [0] Closes: #156 Reported-by: Dan Carpenter <[email protected]> Signed-off-by: Sewon Nam <[email protected]> Signed-off-by: Andrii Nakryiko <[email protected]> Tested-by: Quentin Monnet <[email protected]> Reviewed-by: Quentin Monnet <[email protected]> Link: https://lore.kernel.org/bpf/[email protected]/t/#u Link: https://lore.kernel.org/bpf/[email protected] Signed-off-by: Alexei Starovoitov <[email protected]>
1 parent 452f644 commit 30e4f38

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/prog.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1928,6 +1928,7 @@ static int do_loader(int argc, char **argv)
19281928

19291929
obj = bpf_object__open_file(file, &open_opts);
19301930
if (!obj) {
1931+
err = -1;
19311932
p_err("failed to open object file");
19321933
goto err_close_obj;
19331934
}

0 commit comments

Comments
 (0)