upd addIssueLink() to return bool and not null, to reflect result of … #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesstif
added a commit
that referenced
this pull request
Mar 11, 2022
* 'main' of github.com:lesstif/php-jira-rest-client: upd addIssueLink() to return bool and not null, to reflect result of operation (#414) more precise phpdocs in IssueService (#413) JiraClient: added missing url encoding (#405) Use `#[\ReturnTypeWillChange]` for PHP 7.x compatibility (#404) change issue duedate. Catch passing null to strtolower (#402) Fix return type JsonSerializable implementations (#401) Argument to file_exists() must be string (#400) fix phpdoc (#396) Apply fixes from StyleCI (#395) Add archiveProject (#393) fixed #394 support personal access token based auth fixed #392 save the downloaded file after url decoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding to issue #403 this PR fixes it.
The called get
trueif operation was successfull.