fixed #526 I've implemented getting customField action.

Author: lesstif

src/Issue/CustomField.php

@@ -0,0 +1,41 @@
+<?php
+
+namespace JiraRestApi\Issue;
+
+class CustomField implements \JsonSerializable
+{
+    public int $id;
+
+    public string $name;
+
+    public string $description;
+
+    public array $type;
+
+    public string $searcherKey;
+
+    public array $projectIds;
+
+    public array $issueTypeIds;
+
+    public string $self;
+
+    public int $numericId;
+
+    public bool $isLocked;
+
+    public bool $isManaged;
+
+    public bool $isAllProjects;
+
+    public bool $isTrusted;
+
+    public int $projectsCount;
+
+    public int $screensCount;
+
+    public function jsonSerialize(): mixed
+    {
+        return array_filter(get_object_vars($this));
+    }
+}

src/Issue/CustomFieldSearchResult.php

@@ -0,0 +1,24 @@
+<?php
+
+namespace JiraRestApi\Issue;
+
+class CustomFieldSearchResult implements \JsonSerializable
+{
+    public int $maxResults;
+
+    public int $startAt;
+
+    public int $total;
+
+    public bool $isLast;
+
+    /**
+     * @var array of CustomField
+     */
+    public array $values;
+
+    public function jsonSerialize(): mixed
+    {
+        return array_filter(get_object_vars($this));
+    }
+}

src/Issue/IssueService.php

@@ -822,22 +822,26 @@ public function getPriority(int $priorityId): Priority
      * Get priority by id.
      * throws HTTPException if the priority is not found, or the calling user does not have permission or view it.
      *
-     * @param int $priorityId Id of priority.
+     * @param $paramArray array parameters
      *
      * @throws \JsonMapper_Exception
      * @throws JiraException
      *
-     * @return Priority priority
+     * @return CustomFieldSearchResult array of CustomeFiled
+     *
+     * @see https://docs.atlassian.com/software/jira/docs/api/REST/9.14.0/#api/2/customFields-getCustomFields
      */
-    public function getCustomFields(int $priorityId): Priority
+    public function getCustomFields(array $paramArray = []): CustomFieldSearchResult
     {
-        $ret = $this->exec("priority/$priorityId", null);
+        $ret = $this->exec("customFields".$this->toHttpQueryParameter($paramArray), null);
 
         $this->log->info('Result='.$ret);
 
+        //\JiraRestApi\Dumper::dd(json_decode($ret, false));
+
         return $this->json_mapper->map(
-            json_decode($ret),
-            new Priority()
+            json_decode($ret, false),
+            new CustomFieldSearchResult()
         );
     }
 

src/JiraClient.php

@@ -484,11 +484,14 @@ public function setAPIUri(string $api_uri): string
     /**
      * convert to query array to http query parameter.
      */
-    public function toHttpQueryParameter(array $paramArray): string
+    public function toHttpQueryParameter(array $paramArray, bool $dropNullKey = true): string
     {
         $queryParam = '?';
 
         foreach ($paramArray as $key => $value) {
+            if ($dropNullKey === true && empty($value)) {
+                continue;
+            }
             $v = null;
 
             // some param field(Ex: expand) type is array.

tests/CustomFieldsTest.php

@@ -2,6 +2,7 @@
 
 namespace JiraRestApi\Test;
 
+use JiraRestApi\Issue\IssueService;
 use PHPUnit\Framework\TestCase;
 use JiraRestApi\Dumper;
 use JiraRestApi\Field\Field;
@@ -10,6 +11,37 @@
 
 class CustomFieldsTest extends TestCase
 {
+    /**
+     * @Test
+     *
+     * @return array|string[]|void
+     */
+    public function get_customer_field()
+    {
+        try {
+            $iss = new IssueService();
+
+            $paramArray = [
+                'startAt' => 1,
+                'maxResults' => 50,
+                'search' => null,
+                'projectIds' => [1, 2, 3],
+                'screenIds' => null,
+                'types' => null,
+
+                'sortOrder' => null,
+                'sortColumn' => null,
+                'lastValueUpdate' => null,
+            ];
+            $customerFieldSearchResult = $iss->getCustomFields($paramArray);
+
+            $this->assertLessThan(1, $customerFieldSearchResult->total);
+
+        } catch (JiraException $e) {
+            $this->assertTrue(false, 'testSearch Failed : '.$e->getMessage());
+        }
+    }
+
     public function testGetFields()
     {
         try {
@@ -26,6 +58,7 @@ public function testGetFields()
                     return $matches[0];
                 }, $ret);
 
+            $this->assertTrue(true);
             return $ids;
 
         } catch (JiraException $e) {
@@ -49,6 +82,7 @@ public function testGetFieldOptions($ids)
                     Dumper::dump($ret);
                 }catch (JiraException $e) {}
             }
+            $this->assertTrue(true);
         } catch (JiraException $e) {
             $this->assertTrue(false, 'testGetFieldOptions Failed : '.$e->getMessage());
         }
@@ -69,6 +103,9 @@ public function testCreateFields()
             $fieldService = new FieldService();
 
             $ret = $fieldService->create($field);
+
+            $this->assertTrue(true);
+
             Dumper::dump($ret);
         } catch (JiraException $e) {
             $this->assertTrue(false, 'Field Create Failed : '.$e->getMessage());