fix: check for key upon gen reservation #1561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadir-akhtar
approved these changes
Jul 26, 2025
ypatil12
force-pushed
the
fix/checkKey-ccr
branch
from
b4ac2d0 to
52d1db1
Compare
ypatil12
changed the base branch from
release-dev/multichain-audit-fixes
to
release-dev/multichain-pt2-audit-fixes
ypatil12
merged commit ba2593b
into
release-dev/multichain-pt2-audit-fixes
9 checks passed
ypatil12
added a commit
that referenced
this pull request
Jul 30, 2025
**Motivation:** Currently, we don't require the `KeyType` to be set in the `KeyRegistry` when creating a generation reservation **Modifications:** Update the `CCR` to check for key type. Also update docs **Result:** Stricter user flow
ypatil12
added a commit
that referenced
this pull request
Aug 4, 2025
**Motivation:** Currently, we don't require the `KeyType` to be set in the `KeyRegistry` when creating a generation reservation **Modifications:** Update the `CCR` to check for key type. Also update docs **Result:** Stricter user flow
ypatil12
added a commit
that referenced
this pull request
Aug 8, 2025
**Motivation:** Currently, we don't require the `KeyType` to be set in the `KeyRegistry` when creating a generation reservation **Modifications:** Update the `CCR` to check for key type. Also update docs **Result:** Stricter user flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently, we don't require the
KeyTypeto be set in theKeyRegistrywhen creating a generation reservationModifications:
Update the
CCRto check for key type. Also update docsResult:
Stricter user flow