feat: add calculateCertificateDigestBytes to ECDSA cert verifier (#1532) #1542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Most Ethereum signers, especially the Web3Signer, expect to hash a message payload on their own when signing. This PR adds a version of
calculateCertificateDigest
that doesnt hash the cert digest bytes in order to be compatible with signing libraries that want to hash the payload.Modifications:
Added
calculateCertificateDigestBytes
to the ECDSA Certificate VerifierResult:
We can now use the Web3Signer for signing multichain ECDSA certificates 🎉