feat: cleaner generator updates #1537
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We want to solve two problems:
updateGenerator
will not work in all cases because when we callupdateOperatorTable
, thebn254CertificateVerifier.isRootValidByTimestamp
must be true. This only works if thelatestReferenceTimestamp
for the new generator is the same as what the previous generator was initialized togenerator
Modifications:
setGenerator
and only haveupdateGenerator
referenceTimestamp
fromGenerator
. TheGenerator
always has a reference timestamp ofGENERATOR_REFERENCE_TIMESTAMP
. Now, the reference timestamp is not set in initialization or inupdateGenerator
updateGenerator
can only be called for a new operatorSet.updateOperatorTable
cannot update the table for theGenerator
GENERATOR_GLOBAL_TABLE_ROOT
from being disabledoperatorSetConfig
for thegenerator
referenceTimestamp
andoperatorSetConfig
Also, update documentation & zeus script for
CrossChainRegistry.tableUpdateCadence
Result:
Clearer state machine